bunnei
ef605f7d8f
android: Implement SAF support & migrate to SDK 31. ( #4 )
2023-06-03 00:05:29 -07:00
bunnei
cdbab60bbb
common: error: Fix for Android.
2023-06-03 00:05:27 -07:00
bunnei
f8b87e6fab
common: fs: Implement for Android.
2023-06-03 00:05:27 -07:00
bunnei
99296a1510
common: logging: Implement Android logcat backend.
2023-06-03 00:05:26 -07:00
bunnei
afdee9abea
common: host_memory: Implement for Android.
2023-06-03 00:05:26 -07:00
kkoniuszy
584e8b5c52
host_memory: merge adjacent placeholder mappings on Linux
...
Track the private anonymous placeholder mappings created by Unmap() and
wherever possible, replace existing placeholders with larger ones
instead of creating many small ones.
This helps with the buildup of mappings in /proc/YUZU_PID/maps after a
longer gaming session, improving stability without having to increase
vm.max_map_count to a ridiculous value. The amount of placeholder
mappings will no longer outgrow the amount of actual memfd mappings in
cases of high memory fragmentation.
2023-06-01 22:57:27 +02:00
Morph
9950a388d2
externals: Update to fmt 10 and add format_as formatter for BitField
...
Implicit conversions are now disallowed in fmt 10. Use format_as to convert to the underlying type.
2023-05-28 15:05:55 -04:00
Liam
415c78b87c
textures: add BC1 and BC3 compressors and recompression setting
2023-05-23 12:54:40 -04:00
liamwhite
bbb6b58aa4
Merge pull request #10181 from lat9nq/intel-compute-toggle
...
configure_graphics: Add option to enable compute pipelines for Intel proprietary
2023-05-15 12:05:24 -04:00
liamwhite
182221b9ff
Merge pull request #10132 from Kelebek1/fermi_blit2
...
Allow Fermi blit accelerate to work without images in cache
2023-05-11 10:45:59 -04:00
Kelebek1
bf08bc3c0f
Allow Fermi blit accelerate to add src/dst to the cache if they don't exist already. Use ScratchBuffers in the software blit path.
2023-05-11 06:42:38 +01:00
german77
1968cc7b10
service: nfp: Allow to load with a different amiibo id
2023-05-09 17:51:59 -06:00
Fernando Sahmkow
92da86290c
Settings: add option to enable / disable reactive flushing
2023-05-07 23:46:12 +02:00
Kelebek1
6fed48b3a4
Fix address space allocator slow path to avoid OOB
2023-05-07 15:11:16 +01:00
lat9nq
725aacb4bc
settings: Add enable compute pipelines
...
For the Intel proprietary driver's deficiencies.
settings: Restore compute option global state
2023-05-07 01:06:20 -04:00
bunnei
3547248ec2
Merge pull request #10125 from lat9nq/vsync-select
...
configuration: Expose separate swap present modes
2023-05-06 21:55:39 -07:00
liamwhite
9c9b4616c3
Merge pull request #10167 from german77/motion_preview
...
yuzu: Add motion preview to controller input
2023-05-06 23:09:55 -04:00
Roni Kirla
a13fd5f7cc
Fix read access violation
2023-05-07 00:13:33 +03:00
Narr the Reg
f017335fef
input_common: Add property to invert an axis button
2023-05-05 17:18:35 -06:00
Narr the Reg
46e835f2d6
yuzu: Add motion preview to controller input
2023-05-05 13:53:38 -06:00
Liam
ae59ffc56c
settings: remove pessimistic flushing
2023-05-03 18:52:42 -04:00
Morph
627022bef9
Merge pull request #10124 from liamwhite/pebkac
...
settings: rename extended memory layout to unsafe, move from general to system
2023-05-03 10:52:45 -04:00
lat9nq
2528cf7c54
settings: Enable FIFO relaxed
...
Not entirely sure if we need this, but there's also no reason not to
support it.
settings: Give VSyncMode values
2023-05-02 21:51:30 -04:00
lat9nq
6f0929df82
configuration: Expose separate swap present modes
...
Previously, yuzu would try and guess which vsync mode to use given
different scenarios, but apparently we didn't always get it right. This
exposes the separate modes in a drop-down the user can select.
If a mode isn't available in Vulkan, it defaults to FIFO.
2023-05-02 21:51:29 -04:00
GPUCode
f403d27941
vk_present_manager: Add toggle for async presentation
2023-05-01 23:13:24 +03:00
Liam
2cd9e1ecb6
settings: rename extended memory layout to unsafe, move from general to system
2023-04-30 14:24:22 -04:00
Liam
2afaa7aed7
common: add intrusive list type
2023-04-29 17:46:26 -04:00
Liam
a9623d5f55
general: fixes for gcc 13
2023-04-02 19:02:04 -04:00
Max Dunbar
e446f368d7
Fixes 'Continous' typo
2023-03-29 19:26:12 -07:00
Morph
cdc846677c
telemetry: Add waitpkg instruction
2023-03-27 17:45:22 -04:00
Morph
981bc8aa1c
x64: Simplify RDTSC on non-MSVC compilers
...
Co-Authored-By: liamwhite <liamwhite@users.noreply.github.com>
2023-03-27 17:45:22 -04:00
Morph
27c33ab73f
x64: Add MicroSleep
...
MicroSleep allows the processor to pause for a "short" amount of time (in the microsecond range). This is useful for spin-waiting that does not require nanosecond precision.
This uses the new TPAUSE instruction introduced on Intel's newest processors as part of the waitpkg instructions. For CPUs that do not support waitpkg instructions, this is equivalent to yield().
Co-Authored-By: liamwhite <liamwhite@users.noreply.github.com>
2023-03-27 17:45:22 -04:00
Morph
d2cfe25b07
x64: cpu_detect: Add detection of waitpkg instructions
...
waitpkg introduces 3 instructions, UMONITOR, UMWAIT and TPAUSE.
2023-03-27 17:45:22 -04:00
Liam
7017f04ee8
container_hash: use climits
2023-03-26 10:24:33 -04:00
Morph
9971cd1d55
common: Port boost's hash_value implementation
...
Ports a small subset of boost's hash_value implementation (<= 1.80.0).
2023-03-25 23:52:25 -04:00
Morph
abe2ad7aac
zstd: Use ZSTD_getFrameContentSize instead of ZSTD_getDecompressedSize
2023-03-23 22:16:20 -04:00
liamwhite
ac3927074b
Merge pull request #9971 from Morph1984/q
...
bounded_threadsafe_queue: Use simplified impl of bounded queue
2023-03-23 10:00:31 -04:00
liamwhite
c41a4baf06
Merge pull request #9964 from liamwhite/typed-address
...
kernel: use KTypedAddress for addresses
2023-03-23 10:00:19 -04:00
Liam
fb49ec19c1
kernel: use KTypedAddress for addresses
2023-03-22 09:35:16 -04:00
Morph
197d756560
bounded_threadsafe_queue: Refactor Pop
...
Introduces PopModes to bring waiting logic into Pop, similar to Push.
2023-03-21 22:33:58 -04:00
Morph
8c56481249
bounded_threadsafe_queue: Add producer cv to avoid busy waiting
2023-03-21 22:33:57 -04:00
Morph
407dc917f1
bounded_threadsafe_queue: Deduplicate and add PushModes
...
Adds the PushModes Try and Wait to allow producers to specify how they want to push their data to the queue if the queue is full.
If the queue is full:
- Try will fail to push to the queue, returning false. Try only returns true if it successfully pushes to the queue. This may result in items not being pushed into the queue.
- Wait will wait until a slot is available to push to the queue, resulting in potential for deadlock if a consumer is not running.
2023-03-21 19:20:21 -04:00
Morph
15d573194c
bounded_threadsafe_queue: Add TryPush
2023-03-21 19:17:38 -04:00
Morph
f28ca5361f
logging: Make use of bounded queue
2023-03-21 19:17:38 -04:00
Morph
306840a580
bounded_threadsafe_queue: Use simplified impl of bounded queue
...
Provides a simplified SPSC, MPSC, and MPMC bounded queue implementation using mutexes.
2023-03-21 19:17:32 -04:00
bunnei
00d401d639
common: string_util: Use std::string_view for UTF16ToUTF8/UTF8ToUTF16W.
2023-03-18 22:42:25 -07:00
bunnei
0eb3fa05e5
common: bounded_threadsafe_queue: Use polyfill_thread.
2023-03-17 23:42:17 -07:00
Liam
600f325d87
general: fix spelling mistakes
2023-03-12 11:33:01 -04:00
liamwhite
021af4fd00
Merge pull request #9917 from Morph1984/the-real-time
...
native_clock: Re-adjust the RDTSC frequency to its real frequency
2023-03-10 13:55:11 -05:00
bunnei
4562f7af9a
Merge pull request #9906 from german77/metroid2
...
input_common: Increase mouse sensitivity range
2023-03-08 10:43:38 -08:00
Morph
a3ffea6a64
Merge pull request #9918 from liamwhite/fwrapv
...
kernel: avoid signed overflow UB on MSVC
2023-03-07 22:42:32 -05:00
Morph
b014fdacdb
Merge pull request #9920 from liamwhite/constexpr-bit-cast
...
common: make BitCast constexpr
2023-03-07 22:42:19 -05:00
Morph
d718eab351
native_clock: Wait for 10 seconds instead of 30
...
It was experimentally determined to be sufficient.
2023-03-07 21:17:46 -05:00
Morph
c27a626b5b
native_clock: Use RealTimeClock instead of SteadyClock
...
We want to synchronize RDTSC to real time.
2023-03-07 21:17:46 -05:00
Morph
6f9918552c
steady_clock: Introduce a real time clock
2023-03-07 21:17:46 -05:00
Morph
dcd13a7566
native_clock: Re-adjust the RDTSC frequency
...
The RDTSC frequency reported by CPUID is not accurate to its true frequency.
We will spawn a separate thread to calculate the true RDTSC frequency after a measurement period of 30 seconds has elapsed.
2023-03-07 21:17:46 -05:00
Narr the Reg
757aafa582
input_common: Minor typo issues ( #9922 )
2023-03-08 03:15:46 +01:00
german77
9a9e5844d3
input_common: Increase mouse sensitivity range
2023-03-07 19:31:52 -06:00
Liam
64dcb40db1
common: make BitCast constexpr
2023-03-07 20:26:56 -05:00
Liam
d45ac00d48
kernel: avoid signed overflow UB on MSVC
2023-03-07 19:46:48 -05:00
liamwhite
a7792e5ff8
Merge pull request #9889 from Morph1984/time-is-ticking
...
core_timing: Reduce CPU usage on Windows
2023-03-07 10:54:13 -05:00
Ikko Eltociear Ashimine
c161e3f433
fix typo in settings.h
...
Intial -> Initial
2023-03-06 20:28:47 +09:00
Morph
376a414f5b
native_clock: Round RDTSC frequency to the nearest 1000
2023-03-05 02:36:31 -05:00
Morph
026eaddbee
timer_resolution: Set current process to High QoS
...
Ensures that this process is treated as a high performance process by the Windows scheduler.
2023-03-05 02:36:31 -05:00
Morph
bff1453282
core_timing: Use higher precision sleeps on Windows
...
The precision of sleep_for and wait_for is limited to 1-1.5ms on Windows.
Using SleepForOneTick() allows us to sleep for exactly one interval of the current timer resolution.
This allows us to take advantage of systems that have a timer resolution of 0.5ms to reduce CPU overhead in the event loop.
2023-03-05 02:36:31 -05:00
Morph
7fffdf83b7
wall_clock: Make use of SteadyClock
2023-03-05 02:36:31 -05:00
Morph
1ed49f92dd
common: Implement a method to change the Windows timer resolution
...
This utilizes undocumented NtDll functions to change the current timer resolution from the default of 1ms.
2023-03-05 01:41:28 -05:00
Morph
bd09c82521
common: Implement a high resolution steady clock
...
This implementation provides a consistent, high performance, and high resolution clock where/when std::chrono::steady_clock does not provide sufficient precision.
2023-03-05 01:41:19 -05:00
Liam
809148e1a5
nvnflinger: fix name
2023-03-01 10:39:49 -05:00
Alexandre Bouvier
57fd8b1f45
cmake: use correct boost imported targets
2023-02-28 17:56:01 +01:00
Narr the Reg
ff11fdb07e
Revert "yuzu: config: Remove player 8 and 9 from config file"
2023-02-26 14:39:13 -06:00
liamwhite
26c1edf2f0
Merge pull request #9849 from ameerj/async-astc
...
texture_cache: Add asynchronous ASTC texture decoding
2023-02-26 09:20:12 -05:00
Narr the Reg
60688bf0d5
yuzu: config: Remove player 8 and 9 from config file
2023-02-25 22:20:32 -06:00
ameerj
b5bcd8c71b
configuration: Add async ASTC decode setting
2023-02-22 18:21:09 -05:00
ameerj
090bc588e5
texture_cache: Add async texture decoding
2023-02-22 00:26:07 -05:00
Narr the Reg
db2785082b
settings: Add more input settings to the log
2023-02-21 19:48:38 -06:00
m-HD
9df92bad2a
Update settings.cpp
...
added missing graphical settings to RestoreGlobalState()
2023-02-12 02:58:39 +01:00
Narr the Reg
acba9a6b76
input_common: Reintroduce custom pro controller support
2023-02-09 20:08:54 -06:00
ameerj
2d2522693e
Revert "Merge pull request #9718 from yuzu-emu/revert-9508-hle-ipc-buffer-span"
...
This reverts commit 25fc5c0e11
, reversing
changes made to af20e25081
.
2023-02-03 00:08:45 -05:00
liamwhite
b01698775b
Revert "hle_ipc: Use std::span to avoid heap allocations/copies when calling ReadBuffer"
2023-02-02 15:53:28 -05:00
bunnei
92c5ab33b7
Merge pull request #9696 from german77/please_forgive_me_for_this_sin
...
input_common: Implement turbo buttons
2023-02-01 12:08:34 -08:00
german77
75e81885b0
input_common: Implement turbo buttons
2023-02-01 12:42:05 -06:00
bunnei
ed4a88bd93
Merge pull request #9508 from ameerj/hle-ipc-buffer-span
...
hle_ipc: Use std::span to avoid heap allocations/copies when calling ReadBuffer
2023-01-30 12:17:09 -08:00
Levi Behunin
d5fc56db4b
Move to Clang Format 15
...
Depends on https://github.com/yuzu-emu/build-environments/pull/69
clang-15 primary run
2023-01-29 17:49:42 -07:00
Liam
619c0e70f0
polyfill_thread: satisfy execution ordering requirements of stop_callback
2023-01-27 21:34:49 -05:00
Morph
9b0563fa87
polyfill_thread: Implement StoppableTimedWait
...
StoppableTimedWait allows for a timed wait to be stopped immediately after a stop is requested.
This is useful in cases where long duration thread sleeps are needed and allows for immediate joining of waiting threads after a stop is requested.
Co-Authored-By: liamwhite <liamwhite@users.noreply.github.com>
2023-01-25 16:43:04 -05:00
bunnei
44b981fd3e
Merge pull request #9662 from abouvier/cmake-llvm
...
cmake: prefer system llvm library
2023-01-24 11:03:14 -08:00
liamwhite
a68af583ea
Merge pull request #9492 from german77/joycon_release
...
Input_common: Implement custom joycon driver v2
2023-01-24 09:29:37 -05:00
Alexandre Bouvier
34b1ea9c19
cmake: prefer system llvm library
2023-01-23 06:23:00 +01:00
liamwhite
9705094a57
Merge pull request #9613 from Kelebek1/demangle
...
Add stacktrace symbol demangling
2023-01-22 13:13:58 -05:00
german77
527dad7097
input_common: Use DriverResult on all engines
2023-01-19 18:05:22 -06:00
Narr the Reg
2d802893e7
input_common: Disable SDL driver with switch controllers
2023-01-19 18:05:20 -06:00
Narr the Reg
d80e6c399b
input_common: Initial skeleton for custom joycon driver
2023-01-19 18:05:20 -06:00
Kelebek1
42b16bb33a
Be careful of mangled out of bounds read
2023-01-14 19:53:55 +00:00
Kelebek1
ce0b8d618d
Move demangle impl to cpp
2023-01-14 05:12:41 +00:00
Kelebek1
80a55c1663
Add stacktrace symbol demangling
2023-01-14 04:43:21 +00:00
Matías Locatti
d7dbd8e774
Update settings.h
2023-01-13 04:56:25 -03:00
Matías Locatti
4294429a07
CPP
2023-01-13 04:55:26 -03:00
Matías Locatti
3ba53f2511
1.5X resolution scaler option
2023-01-13 02:34:24 -03:00
Liam
0df43e4e07
renderer_vulkan: disable turbo by default
2023-01-08 11:38:30 -05:00
bunnei
66e4a48b75
Merge pull request #9563 from german77/crash_not_allowed
...
input_common: Create an update engine
2023-01-07 13:41:27 -08:00
liamwhite
020dbcdbc7
Merge pull request #9552 from liamwhite/turbo
...
vulkan: implement 'turbo mode' clock booster
2023-01-06 09:59:59 -05:00
Narr the Reg
8042ce7e19
input_common: Create an update engine
2023-01-05 19:24:29 -06:00
Wollnashorn
8945fafcc0
config: Set the Vulkan driver pipeline cache option to be global
2023-01-05 21:03:01 +01:00
Wollnashorn
f4626512ff
config: Better wording for VK pipeline cache option and enable by default
2023-01-05 21:03:01 +01:00
Wollnashorn
16809c1fa7
video_core/vulkan: Added VkPipelineCache
to store Vulkan pipelines
...
As an optional feature which can be enabled in the advanced graphics configuration, all pipelines that get built at the initial shader loading are stored in a VkPipelineCache object and are dumped to the disk.
These vendor specific pipeline cache files are located at `/shader/GAME_ID/vulkan_pipelines.bin`. This feature was mainly added because of an issue with the AMD driver (see yuzu-emu#8507) causing invalidation of the cache files the driver builds automatically.
2023-01-05 21:02:44 +01:00
Liam
a4269c285a
common: add setting for renderer clock workaround
2023-01-04 22:22:01 -05:00
Fernando Sahmkow
3ecc03ec1b
yuzu-ui: Add setting for disabling macro HLE
2023-01-04 14:56:52 -05:00
Fernando Sahmkow
a0c697124c
Video_core: Address feedback
2023-01-04 14:39:42 -05:00
Fernando Sahmkow
d09aa0182f
MacroHLE: Final cleanup and fixes.
2023-01-01 16:43:58 -05:00
Fernando Sahmkow
18637766ef
MacroHLE: Reduce massive calculations on sizing estimation.
2023-01-01 16:43:57 -05:00
Merry
fd1831b65b
host_memory: Use transparent huge pages where available
2023-01-01 11:40:35 +00:00
Merry
4d7be85e73
host_memory: Allocate virtual_base with MAP_NORESERVE
...
Specify that we do not require swap to be reserved for this address range;
allow overcommitting.
2023-01-01 11:40:35 +00:00
ameerj
fbc375f0de
fsp_srv: Use ReadBufferSpan
2022-12-25 13:21:15 -05:00
ameerj
c6590ad07b
scratch_buffer: Explicitly defing resize and resize_destructive functions
...
resize keeps previous data intact when the buffer grows
resize_destructive destroys the previous data when the buffer grows
2022-12-19 22:40:50 -05:00
ameerj
64869807e2
tests: Add ScratchBuffer tests
2022-12-19 18:08:04 -05:00
ameerj
cfc34dd41d
common: Add ScratchBuffer class
...
This class creates a default initialized heap allocated buffer for cases where value initializing members during allocation or resize
is redundant.
2022-12-19 18:07:51 -05:00
ameerj
88ba5a7f22
common: add make_unique_for_overwrite
2022-12-19 18:07:42 -05:00
Matías Locatti
fd1ea0fd84
Enable compiler optimizations and enforce x86-64-v2 on GCC/Clang ( #9442 )
...
* Testing LTO (#4 )
* Testing LTO
* clang
* linux
* Added the rest of Blinkhawk's optimizations
* Unlikely asserts
* Removing LTO from Linux builds - GCC
* Removing LTO from Linux builds - Clang
2022-12-17 17:16:52 -08:00
Chloe Marcec
c5f519e1e4
Set: Allow setting device nickname
2022-12-13 19:54:17 -05:00
bunnei
339a37f8cb
Merge pull request #9398 from liamwhite/fail
...
general: improve handling of system startup failure
2022-12-12 14:37:42 -08:00
Mai
d5684dbe7d
Merge pull request #9415 from liamwhite/dc
...
memory: correct semantics of data cache management operations
2022-12-11 21:09:31 +00:00
Liam
ed37192441
memory: correct semantics of data cache management operations
2022-12-11 12:46:34 -05:00
Liam
5b837157bd
video_core: Integrate SMAA
...
Co-authored-by: goldenx86 <goldenx86@users.noreply.github.com>
Co-authored-by: BreadFish64 <breadfish64@users.noreply.github.com>
2022-12-08 17:17:45 -05:00
Liam
9704acb982
general: improve handling of system startup failure
2022-12-06 16:13:42 -05:00
merry
e1f5f4bdea
Merge pull request #9370 from liamwhite/break-unmapped
...
core: add option to break on unmapped access
2022-12-06 20:20:20 +00:00
liamwhite
3b19f741bd
Merge pull request #6833 from abouvier/unbundle
...
cmake: prefer system libraries
2022-12-05 12:26:09 -05:00
liamwhite
522e7c5663
Merge pull request #9273 from ameerj/per-game-profile
...
Configuration: Add per-game input profiles
2022-12-04 13:38:01 -05:00
Alexandre Bouvier
8e17b5469f
cmake: prefer system libraries
2022-12-04 17:09:25 +01:00
bunnei
f77cc6c412
Merge pull request #9344 from liamwhite/null
...
video_core: add null backend
2022-12-03 11:23:25 -08:00
liamwhite
75e16547f8
Merge pull request #9300 from ameerj/pch
...
CMake: Use precompiled headers to improve compile times
2022-12-03 14:10:06 -05:00
liamwhite
22aff09b33
Merge pull request #9289 from liamwhite/fruit-company
...
general: fix compile for Apple Clang
2022-12-03 12:09:21 -05:00
Liam
6072b22a0b
core: add option to break on unmapped access
2022-12-02 08:25:45 -05:00
ameerj
5b5612c1cc
CMake: Consolidate common PCH headers
2022-11-30 18:30:30 -05:00
ameerj
3c39c0ac3e
string_util: Fix Mingw compile error
...
Co-Authored-By: liamwhite <9658600+liamwhite@users.noreply.github.com>
2022-11-30 18:26:26 -05:00
ameerj
37bc5118ea
CMake: Use precompiled headers
2022-11-29 18:50:49 -05:00
Liam
89dd7dc180
video_core: add null backend
2022-11-28 19:49:09 -05:00
Morph
bbb963a31a
Merge pull request #9339 from lioncash/cacheheader
...
common/cache_management: Amend header includes
2022-11-28 13:12:20 -05:00
Lioncash
c2c9b44749
common/cache_management: Amend header includes
...
Narrows the include in the header to <cstddef>, since that's what houses
size_t's definition, meanwhile the <cstdint> include can be moved into
the cpp file.
2022-11-28 10:19:53 -05:00
Lioncash
2ec7d0b5fd
common/input: Add helpers functions for creating input and output devices
...
Avoids the redundancy of needing to explictly specify the common
namespace and the type.
2022-11-28 10:00:37 -05:00
Lioncash
7f42432f42
common/input: Pass ParamPackage by const reference in CreateDevice
...
This was previously being passed by value, which was unnecessary and
created more allocations than necessary.
2022-11-28 09:11:58 -05:00
bunnei
3ab8d9ac7c
Merge pull request #9276 from goldenx86/fsrSlider
...
FSR Sharpening Slider
2022-11-27 00:13:15 -08:00
Matías Locatti
701ca96827
Oops
2022-11-26 17:39:43 -03:00
Matías Locatti
26211ac339
Replace GLSL as the default OpenGL shader backend
...
GLASM is not very compatible with the latest games, and too many people have the special superpower to break their Vulkan support.
2022-11-26 17:27:04 -03:00
lat9nq
b670c350e4
settings: Reset FSR sharpening global state with the others
2022-11-25 22:42:24 -05:00
Matías Locatti
f209e976f4
FSR Sharpening Slider part 1 - only a global slider
2022-11-24 04:22:13 -05:00
Liam
9737615948
general: fix compile for Apple Clang
2022-11-22 22:22:28 -05:00
ameerj
9efdad6a27
Configuration: Add per-game input profiles
2022-11-20 14:06:31 -05:00
bunnei
1fb33bd1e1
Merge pull request #9234 from liamwhite/data-cash-money
...
kernel: implement data cache management operations
2022-11-18 13:18:36 -08:00
Morph
e5a446a0df
Merge pull request #9229 from Docteh/achy_breaky_heart
...
Add break for default cases
2022-11-17 19:20:18 -05:00