Services: Added a todo about returning interfaces as domain objects in lm, hid and time.

This commit is contained in:
Subv 2018-01-22 17:59:24 -05:00
parent 7efa6e8801
commit b0489c9a64
3 changed files with 12 additions and 0 deletions

View file

@ -169,6 +169,9 @@ private:
applet_resource = std::make_shared<IAppletResource>(); applet_resource = std::make_shared<IAppletResource>();
} }
// TODO(Subv): Verify if this should return the interface as a domain object when called
// from within a domain.
auto sessions = Kernel::ServerSession::CreateSessionPair(applet_resource->GetServiceName()); auto sessions = Kernel::ServerSession::CreateSessionPair(applet_resource->GetServiceName());
auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions); auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions);

View file

@ -146,6 +146,9 @@ void InstallInterfaces(SM::ServiceManager& service_manager) {
* 0: ResultCode * 0: ResultCode
*/ */
void LM::Initialize(Kernel::HLERequestContext& ctx) { void LM::Initialize(Kernel::HLERequestContext& ctx) {
// TODO(Subv): Verify if this should return the interface as a domain object when called from
// within a domain.
auto logger = std::make_shared<Logger>(); auto logger = std::make_shared<Logger>();
auto sessions = Kernel::ServerSession::CreateSessionPair(logger->GetServiceName()); auto sessions = Kernel::ServerSession::CreateSessionPair(logger->GetServiceName());
auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);

View file

@ -83,6 +83,8 @@ private:
}; };
void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) { void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) {
// TODO(Subv): Verify if this should return the interface as a domain object when called from
// within a domain.
auto system_clock = std::make_shared<ISystemClock>(); auto system_clock = std::make_shared<ISystemClock>();
auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName()); auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@ -95,6 +97,8 @@ void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ct
} }
void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) { void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) {
// TODO(Subv): Verify if this should return the interface as a domain object when called from
// within a domain.
auto system_clock = std::make_shared<ISystemClock>(); auto system_clock = std::make_shared<ISystemClock>();
auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName()); auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@ -107,6 +111,8 @@ void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext&
} }
void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) { void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) {
// TODO(Subv): Verify if this should return the interface as a domain object when called from
// within a domain.
auto steady_clock = std::make_shared<ISteadyClock>(); auto steady_clock = std::make_shared<ISteadyClock>();
auto sessions = Kernel::ServerSession::CreateSessionPair(steady_clock->GetServiceName()); auto sessions = Kernel::ServerSession::CreateSessionPair(steady_clock->GetServiceName());
auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions); auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);