From b0489c9a64588d2140d9a98b69c5a0adc541a436 Mon Sep 17 00:00:00 2001
From: Subv <subv2112@gmail.com>
Date: Mon, 22 Jan 2018 17:59:24 -0500
Subject: [PATCH] Services: Added a todo about returning interfaces as domain
 objects in lm, hid and time.

---
 src/core/hle/service/hid/hid.cpp   | 3 +++
 src/core/hle/service/lm/lm.cpp     | 3 +++
 src/core/hle/service/time/time.cpp | 6 ++++++
 3 files changed, 12 insertions(+)

diff --git a/src/core/hle/service/hid/hid.cpp b/src/core/hle/service/hid/hid.cpp
index 9b1e680f1..ae60cc7b4 100644
--- a/src/core/hle/service/hid/hid.cpp
+++ b/src/core/hle/service/hid/hid.cpp
@@ -169,6 +169,9 @@ private:
             applet_resource = std::make_shared<IAppletResource>();
         }
 
+        // TODO(Subv): Verify if this should return the interface as a domain object when called
+        // from within a domain.
+
         auto sessions = Kernel::ServerSession::CreateSessionPair(applet_resource->GetServiceName());
         auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
         auto client = std::get<Kernel::SharedPtr<Kernel::ClientSession>>(sessions);
diff --git a/src/core/hle/service/lm/lm.cpp b/src/core/hle/service/lm/lm.cpp
index dd0f75ce1..b505cdcaf 100644
--- a/src/core/hle/service/lm/lm.cpp
+++ b/src/core/hle/service/lm/lm.cpp
@@ -146,6 +146,9 @@ void InstallInterfaces(SM::ServiceManager& service_manager) {
  *      0: ResultCode
  */
 void LM::Initialize(Kernel::HLERequestContext& ctx) {
+    // TODO(Subv): Verify if this should return the interface as a domain object when called from
+    // within a domain.
+
     auto logger = std::make_shared<Logger>();
     auto sessions = Kernel::ServerSession::CreateSessionPair(logger->GetServiceName());
     auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
diff --git a/src/core/hle/service/time/time.cpp b/src/core/hle/service/time/time.cpp
index 9039a4cec..8abb2ce7a 100644
--- a/src/core/hle/service/time/time.cpp
+++ b/src/core/hle/service/time/time.cpp
@@ -83,6 +83,8 @@ private:
 };
 
 void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ctx) {
+    // TODO(Subv): Verify if this should return the interface as a domain object when called from
+    // within a domain.
     auto system_clock = std::make_shared<ISystemClock>();
     auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
     auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@@ -95,6 +97,8 @@ void Module::Interface::GetStandardUserSystemClock(Kernel::HLERequestContext& ct
 }
 
 void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext& ctx) {
+    // TODO(Subv): Verify if this should return the interface as a domain object when called from
+    // within a domain.
     auto system_clock = std::make_shared<ISystemClock>();
     auto sessions = Kernel::ServerSession::CreateSessionPair(system_clock->GetServiceName());
     auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);
@@ -107,6 +111,8 @@ void Module::Interface::GetStandardNetworkSystemClock(Kernel::HLERequestContext&
 }
 
 void Module::Interface::GetStandardSteadyClock(Kernel::HLERequestContext& ctx) {
+    // TODO(Subv): Verify if this should return the interface as a domain object when called from
+    // within a domain.
     auto steady_clock = std::make_shared<ISteadyClock>();
     auto sessions = Kernel::ServerSession::CreateSessionPair(steady_clock->GetServiceName());
     auto server = std::get<Kernel::SharedPtr<Kernel::ServerSession>>(sessions);