browse: Clarify test skip on Windows and log a message

This commit is contained in:
Matthew Holt 2017-08-26 07:14:40 -06:00
parent 0b4dda0aba
commit 0a31c32fb7
No known key found for this signature in database
GPG key ID: 2A349DD577D586A5

View file

@ -3,6 +3,7 @@ package browse
import ( import (
"context" "context"
"encoding/json" "encoding/json"
"fmt"
"io/ioutil" "io/ioutil"
"net/http" "net/http"
"net/http/httptest" "net/http/httptest"
@ -461,7 +462,10 @@ func TestBrowseRedirect(t *testing.T) {
func TestDirSymlink(t *testing.T) { func TestDirSymlink(t *testing.T) {
if runtime.GOOS == "windows" { if runtime.GOOS == "windows" {
return // TODO: Temporarily skipping these tests on Windows, so we can get a release out that fixes the build server // Windows support for symlinks is limited, and we had a hard time getting
// all these tests to pass with the permissions of CI; so just skip them
fmt.Println("Skipping browse symlink tests on Windows...")
return
} }
testCases := []struct { testCases := []struct {