From 0a31c32fb7d5f8765c7768acd329d830addccb6b Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Sat, 26 Aug 2017 07:14:40 -0600 Subject: [PATCH] browse: Clarify test skip on Windows and log a message --- caddyhttp/browse/browse_test.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/caddyhttp/browse/browse_test.go b/caddyhttp/browse/browse_test.go index cd27c2c9f..08022d698 100644 --- a/caddyhttp/browse/browse_test.go +++ b/caddyhttp/browse/browse_test.go @@ -3,6 +3,7 @@ package browse import ( "context" "encoding/json" + "fmt" "io/ioutil" "net/http" "net/http/httptest" @@ -461,7 +462,10 @@ func TestBrowseRedirect(t *testing.T) { func TestDirSymlink(t *testing.T) { if runtime.GOOS == "windows" { - return // TODO: Temporarily skipping these tests on Windows, so we can get a release out that fixes the build server + // Windows support for symlinks is limited, and we had a hard time getting + // all these tests to pass with the permissions of CI; so just skip them + fmt.Println("Skipping browse symlink tests on Windows...") + return } testCases := []struct {