Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
10176 commits 1 branch 0 tags 102 MiB
Commit graph

4953 commits

Author SHA1 Message Date
Zach Hilman
c7b6c9de9c am: Move IStorageAccessor to header and update backing buffer 
Writes to an AM::IStorage object through an IStorageAccessor will now be preserved once the accessor is destroyed.
 2018-11-18 10:53:47 -05:00
Zach Hilman
76d515327b am: Implement CreateTransferMemoryStorage 
Creates an AM::IStorage object with the contents of the transfer memory located at the handle provided.
 2018-11-18 10:53:47 -05:00
Zach Hilman
7901de2b75 svc: Implement svcCreateTransferMemory 
Seems to be used and created identically to SharedMemory, so just reuse that.
 2018-11-18 10:53:47 -05:00
Zach Hilman
51af996854 ldr_ro: Add error check for memory allocation failure 2018-11-17 21:40:26 -05:00
Zach Hilman
c91dc417d5 vi: Implement TransactParcel for Disconnect and DetachBuffer 
Used by homebrew on exit. According to switchbrew, returns an empty response parcel with one zero in it.
 2018-11-17 17:10:19 -05:00
MysticExile
03f274d8c1 Stubbed am:EnableApplicationCrashReport 2018-11-17 15:05:55 +01:00
bunnei
0149b4245c
Merge pull request #1711 from ogniK5377/bluetooth-lets-go 
Added various bluetooth based cmds for palma
 2018-11-16 20:08:36 -08:00
bunnei
6552d75be1
Merge pull request #1719 from bunnei/hwopus-fix 
hwopus: DecodeInterleavedWithPerformance: Fix ordering of output parameters.
 2018-11-16 20:08:17 -08:00
bunnei
585e6fd426 hwopus: DecodeInterleavedWithPerformance: Fix ordering of output parameters. 
- Fixes audio issues with Pokemon: Let's Go Pikachu & Eevee.
 2018-11-16 22:54:38 -05:00
David Marcec
c440e8b8e1 Implemented CalculateStandardUserSystemClockDifferenceByUser 
Seems pokemon calls this sometimes and it caused "random crashes"
 2018-11-17 14:01:16 +11:00
Lioncash
d21b2164e9 kernel/errors: Clean up error codes 
Similar to PR 1706, which cleans up the error codes for the filesystem
code, but done for the kernel error codes. This removes the ErrCodes
namespace and specifies the errors directly. This also fixes up any
straggling lines of code that weren't using the named error codes where
applicable.
 2018-11-16 14:32:30 -05:00
Mat M
14cede1a0c
Merge pull request #1638 from FreddyFunk/SetMemoryPermission-Stubbed 
Implement SetMemoryPermission
 2018-11-16 10:35:56 -05:00
bunnei
5b8f70ea2e
Merge pull request #1632 from DarkLordZach/keys-manager-optimizations 
game_list: Optimize game list refresh
 2018-11-16 07:02:37 -08:00
bunnei
238bc4a077
Merge pull request #1706 from lioncash/file-err 
file_sys/errors: Clean up error code values
 2018-11-16 06:59:07 -08:00
David Marcec
e8899e7027 Added various bluetooth based cmds for palma 
It seems palma is done through bluetooth, we need this for pokemon go however more research needs to be done when we actually get palma working. This is presumably used for transfering data between the controller and the console, it does not seem for actual input as far as I know.
 2018-11-17 01:42:17 +11:00
David Marcec
e658118aa9 Added SetIsPalmaAllConnectable, SetPalmaBoostMode 
Currently unclear what these do yet, will be researched at a later time when we want to implement palma.
 2018-11-17 01:40:18 +11:00
David Marcec
9359655712 Report resolution scaling support for vi and am 
Specifying an internal resolution in yuzu now will report the scaled changes to vi and am.
 2018-11-16 18:07:42 +11:00
Lioncash
5c9c33e8ad file_sys/errors: Remove currently unused filesystem error codes 
Rather than keeping around unused values, we can just introduce them as
needed.
 2018-11-16 00:18:22 -05:00
Lioncash
edd5b6f12f file_sys/errors: Get rid of the ErrCodes namespace 
There's no real point to keeping the separate enum around, especially
given the name of the error code itself is supposed to document what the
value actually represents.
 2018-11-16 00:13:50 -05:00
Lioncash
b725d1fdf7 file_sys/errors: Extract FS-related error codes to file_sys/errors.h 
Keeps filesystem-related error codes in one spot.
 2018-11-16 00:13:50 -05:00
David
87eca5b209 Fixed priority switching edge case for handheld (#1675) 
* Fixed priority switching edge case for handheld

We accidently used controller index instead of npad id

* Moved NPadIdToIndex
 2018-11-15 20:31:27 -08:00
bunnei
75640c9c71
Merge pull request #1699 from DarkLordZach/deterministic-rng-3 
csrng: Use random integer distribution instead of raw engine
 2018-11-15 20:18:47 -08:00
Zach Hilman
4838bc8ddc fsp_srv: Add support for using open source archive if not found in NAND 2018-11-15 22:35:16 -05:00
Zach Hilman
6aa69880ea file_sys: Add framework for synthesizing open source archives 2018-11-15 22:34:35 -05:00
Zach Hilman
34cd56980f vfs_vector: Add VFS backend for std::array 
Allows using constexpr/static const data with VFS.
 2018-11-15 22:33:52 -05:00
Zach Hilman
8cb2e7d881 csrng: Use random integer distribution instead of raw engine 
Prevents returning the same value every single call.
 2018-11-15 18:44:26 -05:00
bunnei
f7319b0d3c
Merge pull request #1687 from lioncash/deduplication 
kernel/thread: Deduplicate scheduler switching code
 2018-11-15 14:47:42 -08:00
bunnei
97605e36f7
Merge pull request #1618 from DarkLordZach/dump-nso 
patch_manager: Add support for dumping uncompressed NSOs
 2018-11-15 14:46:10 -08:00
bunnei
98060c6f7b
Merge pull request #1691 from lioncash/audren 
service/audren_u: Forward RequestUpdateAuto through the same function as RequestUpdate
 2018-11-15 14:44:36 -08:00
Zach Hilman
c0a9abc3e1 ldr_ro: Implement UnloadNro (command 1) 
Includes actual unmapping and address error checking.
 2018-11-15 12:48:09 -05:00
Zach Hilman
056fa43dcd ldr_ro: Fully Implement LoadNro (command 0) 
Includes NRO and BSS error checking, maximum loaded NRO check, NRR hash check, and proper remapping of BSS data.
 2018-11-15 12:48:09 -05:00
Zach Hilman
5e8e7b6019 ldr_ro: Implement UnloadNrr (command 3) 
Includes initialization check, proper address check, alignment check, and actual unloading of a loaded NRR.
 2018-11-15 12:48:09 -05:00
Zach Hilman
6cd504feb9 ldr_ro: Fully implement LoadNrr (command 2) 
Includes parameter error checking, hash enforcement, initialization check, and max NRR load check.
 2018-11-15 12:48:09 -05:00
Zach Hilman
0276761a1e process: Make MirrorMemory take state to map new memory as 
Credits to Subv
 2018-11-15 12:48:09 -05:00
Zach Hilman
8aa17f0480 pl_u: Resize buffers in shared font data getter to what game requests 
Fixes unmapped spam in SMP and buffer size errors in some other games
 2018-11-15 12:47:36 -05:00
bunnei
c6c74248fe
Merge pull request #1697 from lioncash/acc 
acc/profile_manager: Minor cleanup-related changes
 2018-11-14 19:02:25 -08:00
bunnei
0478308094
Merge pull request #1696 from lioncash/acc-cond 
service/acc: Correct error case within TrySelectUserWithoutInteraction()
 2018-11-14 19:02:16 -08:00
Lioncash
cd47af8af0 service/acc: Correct error case within TrySelectUserWithoutInteraction() 
empty() in this case will always return false, since the returned
container is a std::array. Instead, check if all given users are invalid
before returning the error code.
 2018-11-14 17:43:23 -05:00
Lioncash
9761936e02 profile_manager: Replace iterative loop with a ranged-for loop in ParseUserSaveFile() 2018-11-14 17:13:17 -05:00
Lioncash
1af13e0802 profile_manager: Move UUID Format function definitions into the cpp file 
Avoids relying on fmt always being indirectly included.
 2018-11-14 17:08:59 -05:00
bunnei
c681690358
Merge pull request #1690 from lioncash/nfp 
nfp: Correct erroneous sizeof expression within GetTagInfo()
 2018-11-14 11:55:09 -08:00
bunnei
7384b33c4f
Merge pull request #1689 from lioncash/break 
hid/npad: Add missing break in switch statement within Controller_NPad::OnUpdate
 2018-11-14 11:54:45 -08:00
bunnei
c95ded3a4a
Merge pull request #1688 from lioncash/unused 
service: Mark MakeFunctionString with the [[maybe_unused]] attribute.
 2018-11-14 11:54:29 -08:00
bunnei
e1ea8cc721
Merge pull request #1679 from DarkLordZach/deterministic-rng-2 
svc: Use proper random entropy generation algorithm
 2018-11-14 11:52:27 -08:00
Lioncash
b4f63db04e nfp: Correct erroneous sizeof expression within GetTagInfo() 
The previous expression would copy sizeof(size_t) amount of bytes (8 on
a 64-bit platform) rather than the full 10 bytes comprising the uuid
member.

Given the source and destination types are the same, we can just use an
assignment here instead.
 2018-11-14 12:53:39 -05:00
Lioncash
3619b31fc0 service/audren_u: Forward RequestUpdateAuto through the same function as RequestUpdate 
Based off RE, they both currently go through the same codepath with no
difference in behavior.
 2018-11-14 02:36:21 -05:00
Lioncash
fcde356f15 hid/npad: Add missing break in switch statement within Controller_NPad::OnUpdate() 2018-11-14 00:59:17 -05:00
Lioncash
958fa15a4c service: Mark MakeFunctionString with the [[maybe_unused]] attribute. 
When yuzu is compiled in release mode this function is unused, however,
when compiled in debug mode, it's used within a LOG_TRACE statement.
This prevents erroneous compilation warnings about an unused function
(that isn't actually totally unused).
 2018-11-14 00:49:04 -05:00
Lioncash
f9db75fe40 kernel/thread: Deduplicate scheduler switching code 
The code in both places was the same verbatim, so we can extract it to a
function to deduplicate the logic.
 2018-11-14 00:02:42 -05:00
bunnei
70f189d7af
Merge pull request #1680 from lioncash/mem 
kernel/process: Migrate heap-related memory management out of the process class and into the vm manager
 2018-11-13 18:52:18 -08:00
bunnei
a80467db57
Merge pull request #1682 from lioncash/audio 
hle/audren_u: Implement Get/SetRenderingTimeLimit
 2018-11-13 18:51:44 -08:00
bunnei
9b12623743
Merge pull request #1608 from DarkLordZach/save-data-reader 
[ns|fsp_srv]: Implement various functions to boot Checkpoint
 2018-11-13 18:51:08 -08:00
Lioncash
454cf1dc09 hle/audren_u: Implement Get/SetRenderingTimeLimit 
These appear to be a basic getter and setter pair, so these are fairly
trivial to implement and get out of the way.
 2018-11-13 13:49:09 -05:00
Lioncash
004277477a vm_manager: Unstub GetTotalHeapUsage() 
Now that we've moved all of the heap-related stuff to the VMManager
class, we can unstub this function, as the necessary members are visible
now.
 2018-11-13 13:08:26 -05:00
Lioncash
b8e885c6e5 kernel/process: Migrate heap-related memory management out of the process class and into the vm manager 
Avoids a breach of responsibilities in the interface and keeps the
direct code for memory management within the VMManager class.
 2018-11-13 13:08:19 -05:00
Zach Hilman
ab552e4a25 svc: Use proper random entropy generation algorithm 2018-11-13 12:26:03 -05:00
Hedges
af42320021 GDBStub improvements: 
- Add FPU support
- Fix access to TLS
Fix clang-format.
 2018-11-13 15:44:20 +00:00
bunnei
7f3c2525e6
Merge pull request #1670 from DarkLordZach/deterministic-rng 
csrng: Add config option to set RNG seed
 2018-11-12 21:10:08 -08:00
bunnei
fd72d889bf
Merge pull request #1665 from ogniK5377/GetClockSnapshot 
Implement GetClockSnapshot, ToPosixTime & ToPosixTimeWithMyRule
 2018-11-12 20:13:47 -08:00
Zach Hilman
cb1e63ef09 svc: Return random seed for svcGetInfo RandomEntropy 2018-11-12 21:46:21 -05:00
Zach Hilman
2a16fd7ffc settings: Add config option to set RNG seed 2018-11-11 23:09:46 -05:00
Zach Hilman
4b4f883aef csrng: Use std::mt19937 engine for random number generation 2018-11-11 23:08:39 -05:00
bunnei
7474382266
Merge pull request #1652 from FreddyFunk/static-cast 
configure_system: Fix compiler warning
 2018-11-11 12:19:03 -08:00
James Rowe
93fca5d9cf
Merge pull request #1656 from ogniK5377/message-queue 
Ability to switch between docked and undocked mode in-game
 2018-11-10 11:27:17 -07:00
David Marcec
48cd61d9c8 Added maybe_unused 2018-11-10 18:07:34 +11:00
David Marcec
ddc242dd51 Added ToPosixTime & ToPosixTimeWithMyRule 
Added instead of using a seperate PR to prevent conflicts
 2018-11-10 17:41:57 +11:00
David Marcec
84c6134264 Added consts and static 2018-11-10 12:31:48 +11:00
David Marcec
4f78f5c0df Implement GetClockSnapshot 
Needed by megaman 11
 2018-11-10 01:25:56 +11:00
bunnei
0e05a9d58f
Merge pull request #1658 from ogniK5377/holdtype-style 
Updated npad styles on holdtype switches
 2018-11-07 20:59:01 -08:00
David
581406af18 svcBreak now dumps information from the debug buffer passed (#1646) 
* svcBreak now dumps information from the debug buffer passed

info1 and info2 seem to somtimes hold an address to a buffer, this is usually 4 bytes or the size of the int and contains an error code. There's other circumstances where it can be something different so we hexdump these to examine them at a later date.

* Addressed comments
 2018-11-07 20:43:54 -08:00
David Marcec
a9c25ab9e4 Updated npad styles on holdtype switches 
Fixes input for megaman
 2018-11-08 01:07:14 +11:00
David Marcec
fd1ef25257 Fixups 2018-11-07 20:12:27 +11:00
David Marcec
41e99d8880 Ability to switch between docked and undocked mode in-game 
Started implementation of the AM message queue mainly used in state getters. Added the ability to switch docked mode whilst in game without stopping emulation. Also removed some things which shouldn't be labelled as stubs as they're implemented correctly
 2018-11-07 18:01:33 +11:00
David Marcec
ad45d68871 fixed spelling error 2018-11-07 12:04:43 +11:00
David Marcec
49cb4fa37b Added missing log 2018-11-07 11:46:04 +11:00
David Marcec
92fcc6d15a Implement acc:TrySelectUserWithoutInteraction 
Needed for Shantae - Half-Genie Hero - Ultimate Edition!
 2018-11-07 11:45:01 +11:00
Frederic Laing
d34d0bfc87 configure_system: Fix compiler warning 2018-11-06 16:38:10 +01:00
Frederic Laing
ba2cdcdc5a Implement SetMemoryPermission 2018-11-06 10:21:01 +01:00
bunnei
722e7c05de
Merge pull request #1633 from ogniK5377/reload-input 
Fixed HID crash when launching more than 1 game & signaled styleset change event
 2018-11-05 00:21:27 -05:00
Frederic Laing
1c4365d928 Fix typo in BufferTransformFlags 2018-11-04 16:56:10 +01:00
Zach Hilman
0080a8da58 sm: Implement RegisterService and UnregisterService 
These are needed by Edizon to boot. They are used to see if a user is using SX OS, as SX OS registers a custom service called 'tx' and attempting to register a service of the same name lets the application know if it is present.
 2018-11-03 20:02:18 -04:00
Frederic Laing
ab7472345b Stubbed SetMemoryPermission 2018-11-03 16:01:34 +01:00
David Marcec
03c26d3406 Fixed incorrect hwopus assert 2018-11-02 15:23:38 +11:00
David Marcec
0bc323bafb Fixed HID crash when launching more than 1 game & signaled syleset change event 
This should fix crashes when launching multiple games in yuzu
 2018-11-02 12:35:49 +11:00
Zach Hilman
8f183a47dd filesystem: Cache RegisteredCacheUnion instead of constructing on demand 
Prevents unnecessary re-reads of the metadata and unnecessary temporary objects.
 2018-11-01 20:24:32 -04:00
Zach Hilman
97d425c304 file_sys: Use common KeyManager in NCA container types 
Creates a single KeyManager for the entire container and then passes it into the NCA constructor, eliminating several unnecessary KeyManager reads.
 2018-11-01 20:23:38 -04:00
Zach Hilman
e20db909ee content_archive: Add optional KeyManager parameter to constructor 
Allows resuing a common KeyManager when a large amount of NCAs are handled by the same class. Should the parameter not be provided, a new KeyManager will be constructed, as was the default behavior prior to this.
 2018-11-01 20:22:29 -04:00
bunnei
1069eced84
Merge pull request #1615 from lioncash/input 
configure_system: Contrain profile usernames to 32 characters
 2018-11-01 19:10:26 -04:00
bunnei
d08457f879
Merge pull request #1604 from FearlessTobi/port-4369 
Port citra-emu/citra#4369: "compatdb: Use a seperate endpoint for testcase submission"
 2018-10-31 22:37:07 -04:00
Lioncash
a6830e61b8 configure_system: Contrain profile usernames to 32 characters 
Previously, we would let a user enter an unbounded name and then
silently truncate away characters that went over the 32-character limit.
This is kind of bad from the UX point of view, because we're essentially
not doing what the user intended in certain scenarios.

Instead, we clamp it to 32 characters and make that visually apparent in
the dialog box to provide a name for a user.
 2018-10-31 02:05:00 -04:00
Lioncash
9b9c586dff service/usb: Update IPdSession's function table 
Updated based off information on SwitchBrew.
 2018-10-30 15:23:49 -04:00
Lioncash
352b56367c general: Remove unused boost inclusions where applicable 
Cleans up unused includes and trims off some dependencies on externals.
 2018-10-30 00:09:46 -04:00
Frederic L
7a5eda5914 global: Use std::optional instead of boost::optional (#1578) 
* get rid of boost::optional

* Remove optional references

* Use std::reference_wrapper for optional references

* Fix clang format

* Fix clang format part 2

* Adressed feedback

* Fix clang format and MacOS build
 2018-10-30 00:03:25 -04:00
bunnei
adf26ae668
Merge pull request #1621 from lioncash/ipc 
hle_ipc: Make GetDomainMessageHeader return a regular pointer
 2018-10-29 23:55:59 -04:00
Lioncash
6383653a8d hle_ipc: Add member function for querying the existence of a domain header 
Gets rid of the need to call the getter and then check for null.
 2018-10-29 23:28:04 -04:00
Lioncash
0cc347462d hle_ipc: Make GetDomainMessageHeader return a regular pointer 
Nothing requires the shared owner ship here, so we can just return a
plain pointer.
 2018-10-29 23:18:25 -04:00
Zach Hilman
bdaa76c0db ns: Implement command 400: GetApplicationControlData 
Returns the raw NACP bytes and the raw icon bytes into a title-provided buffer. Pulls from Registration Cache for control data, returning all zeros should it not exist.
 2018-10-29 16:20:16 -04:00
Zach Hilman
1c0226815d patch_manager: Add support for dumping decompressed NSOs 
When enabled in settings, PatchNSO will dump the unmodified NSO that it was passed to a file named <build id>.nso in the dump root for the current title ID.
 2018-10-29 16:10:16 -04:00
Zach Hilman
48eb3742b9 settings: Add setting to control NSO dumping 
Also adds UI option in Debug > Dump section, with the idea later things to be dumped (i.e. other game data or textures, etc) will use the same group box.
 2018-10-29 16:09:08 -04:00
Zach Hilman
9078bb9854 bis_factory: Add getter for mod dump root for a title ID 
Equates to yuzu_dir/dump/<title id>/
 2018-10-29 16:08:03 -04:00
Zach Hilman
5ee19add1b fsp_srv: Implement ISaveDataInfoReader 
An object to read SaveDataInfo objects, which describe a unique save on the system. This implementation iterates through all the directories in the save data space and uses the paths to reconstruct the metadata.
 2018-10-29 13:54:39 -04:00
Zach Hilman
2e8177f0c9 fsp_srv: Implement command 61: OpenSaveDataInfoReaderBySaveDataSpaceId 
Needed by Checkpoint. Returns an object that can iterate through all savedata on the system.
 2018-10-29 13:54:39 -04:00
Zach Hilman
df264d2ccb savedata_factory: Expose accessors for SaveDataSpace 2018-10-29 13:54:38 -04:00
Zach Hilman
f2f679bf3f loader/nro: Call RegisterRomFS from Load 
Allows NRO homebrew to use the RomFS in the ASET section.
 2018-10-29 13:54:38 -04:00
Zach Hilman
b04e39107f control_metadata: Add GetRawBytes function to NACP 
Returns the raw bytes of the NACP file. Needed for GetApplicationControlData which returns the raw, unprocessed NACP to the game.
 2018-10-29 13:54:38 -04:00
Lioncash
a973a049b7 core: Make System references const where applicable 2018-10-28 17:45:29 -04:00
Lioncash
b77f571d20 core: Add missing const variants of getters for the System class 
Many of the Current<Thing> getters (as well as a few others) were
missing const qualified variants, which makes it a pain to retrieve
certain things from const qualified references to System.
 2018-10-28 17:44:58 -04:00
fearlessTobi
585b6a6a50 compatdb: Use a seperate endpoint for testcase submission 2018-10-28 13:23:02 +01:00
bunnei
2239d47112
Merge pull request #1593 from lioncash/svc 
svc: Implement svcGetInfo command 0xF0000002
 2018-10-28 04:38:48 -04:00
Frederic L
72d10ce66c file_sys/patch_manager: Remove unnecessary if-statements (#1586) 
* remove unnecessary if-statements

* Addressed feedback
 2018-10-28 02:30:29 -04:00
bunnei
0d449b77e2
Merge pull request #1598 from DeeJayBro/delete-directory 
service/filesystem: Implemented DeleteDirectory & DeleteDirectoryRecursive
 2018-10-28 02:29:52 -04:00
bunnei
6f620b2441
Merge pull request #1600 from DarkLordZach/nsp-secondary-loader-fix 
loader/nsp: Move secondary loader initialization to constructor
 2018-10-28 02:29:14 -04:00
Zach Hilman
1fa31cf74d key_manager: Use isxdigit instead of isdigit when reading key file 
Crypto revisions are hex numbers and this function only checks if the string is valid for stoul in base 16, so it should be isxdigit.
 2018-10-27 21:56:10 -04:00
Zach Hilman
7c70746ec4 loader/nsp: Move secondary loader initialization to constructor 
Prevents nullptr bug when trying to dump the RomFS of an NSP resulting from secondary_loader not being initialized.
 2018-10-27 10:16:29 -04:00
DeeJayBro
3b1e4c0995 service/filesystem: Add DirectoryDelete & DirectoryDeleteRecursively 2018-10-27 11:56:39 +02:00
Lioncash
7de8e36343 svc: Localize the GetInfo enum class to the function itself 
Nothing from this enum is intended to be used outside of this function.
 2018-10-26 12:49:14 -04:00
Lioncash
6594853eb1 svc: Implement svcGetInfo command 0xF0000002 
This retrieves:

if (curr_thread == handle_thread) {
   result = total_thread_ticks + (hardware_tick_count - last_context_switch_ticks);
} else if (curr_thread == handle_thread && sub_id == current_core_index) {
   result = hardware_tick_count - last_context_switch_ticks;
}
 2018-10-26 12:49:11 -04:00
bunnei
72e6b31a07
Merge pull request #1430 from DarkLordZach/remove-promote-dir 
vfs: Remove InterpretAsDirectory and related functions
 2018-10-26 00:15:34 -04:00
bunnei
debabf1fa6
Merge pull request #1569 from lioncash/amiibo 
yuzu/main: Notify user of loading errors with Amiibo data
 2018-10-25 22:10:08 -04:00
bunnei
cebce2a93a ldr: Partially implement LoadNro. 
- This is an incomplete implementation. It was tested with Super Mario Party.
 2018-10-25 18:03:54 -04:00
bunnei
c2049aa4e5 process: LoadModule should clear JIT instruction cache. 2018-10-25 18:03:54 -04:00
bunnei
a609b6907a Kernel/Memory: Added a function to first a suitable guest address at which to allocate a region of a given size. 2018-10-25 18:03:54 -04:00
bunnei
ef7b2237d9 nro: Make LoadNro method accessible outside of apploader code. 2018-10-25 18:03:54 -04:00
Zach Hilman
9a87ece837 ips_layer: Use rle_size instead of data_size in RLE patch application 
Prevents a potential bug when using RLE records in an IPS patch.
 2018-10-25 14:23:56 -04:00
bunnei
2bc2b32662
Merge pull request #1579 from lioncash/usb 
service/usb: Update service function tables
 2018-10-25 12:22:57 -04:00
bunnei
0634aee267
Merge pull request #1576 from lioncash/acc-warn 
service/acc: Silence compiler truncation warnings
 2018-10-25 12:22:10 -04:00
bunnei
c94db0e071
Merge pull request #1577 from lioncash/err 
kernel/error: Amend error return code values
 2018-10-25 01:10:26 -04:00
Lioncash
fbbb58b226 service/usb: Update service function tables 
Updated based off the information provided by Hexkyz on Switchbrew.
 2018-10-24 19:07:55 -04:00
Lioncash
1e3b139cd7 service/acc: Move fallback image to file scope 
This is just flat data, so it doesn't really need to be in the function
itself. This also allows deduplicating the constant for the backup size
in GetImageSize().
 2018-10-24 18:22:24 -04:00
Lioncash
6f00628564 service/acc: Silence compiler warnings 
Silences compiler warnings related to truncation. This also introduces a
small helper function to perform the clamping of the image size.
 2018-10-24 18:22:24 -04:00
Lioncash
3ec90dc6ef service/acc: Early return in failure case in LoadImage() 
Allows unindenting the other branch's code.
 2018-10-24 18:22:20 -04:00
bunnei
9aa5c1894e
Merge pull request #1570 from lioncash/optional 
profile_manager: Use std::optional instead of boost::optional
 2018-10-24 18:11:03 -04:00
bunnei
ce2403d975
Merge pull request #1564 from lioncash/npad 
npad: Remove unused controller variable from OnInit()
 2018-10-24 17:36:55 -04:00
bunnei
ddff188c65
Merge pull request #1563 from lioncash/frame 
perf_stats: Remove unused variable within DoFrameLimiting()
 2018-10-24 16:29:16 -04:00
bunnei
d14ba122e2
Merge pull request #1562 from lioncash/aoc 
aoc_u: Make use of previously-unused CheckAOCTitleIDMatchesBase() function
 2018-10-24 16:28:56 -04:00
bunnei
cdd499c261
Merge pull request #1561 from lioncash/fs 
file_sys: Remove unused variables
 2018-10-24 16:28:17 -04:00
Lioncash
1fb4bebb63 kernel/errors: Remove now-unused, unnecessary, error codes 
Now that we've gotten the innaccurate error codes out of the way, we can
finally toss away a bunch of these, trimming down the error codes to
ones that are actually used and knocking out two TODO comments.
 2018-10-24 14:58:37 -04:00
Lioncash
239dfea34a kernel/shared_memory: Return ERR_INVALID_MEMORY_PERMISSIONS instead of ERR_INVALID_COMBINATION 
This is more consistent with what the kernel does.
 2018-10-24 14:54:36 -04:00
Lioncash
474bc29208 kernel/server_port: Simplify emptiness check within ShouldWait() 2018-10-24 14:24:36 -04:00
Lioncash
b703aba622 kernel/server_port: Change error case return value in Accept() to ERR_NOT_FOUND 
This is what the kernel does in this instance.
 2018-10-24 14:23:38 -04:00
Lioncash
afb7e5cc05 kernel/error: Remove leftover 3DS error codes 
These are now entirely unused and can be removed.
 2018-10-24 14:21:37 -04:00
Lioncash
fcf8f53a63 kernel/svc: Amend returned error code for invalid priorities in CreateThread 
Like with the previous change, the kernel doesn't return NOT_AUTHORIZED
here. It returns INVALID_THREAD_PRIORITY.
 2018-10-24 14:11:11 -04:00
Lioncash
77328b0f19 kernel/svc: Move and correct returned error code for invalid thread priorities in SetThreadPriority() 
All priority checks are supposed to occur before checking the validity
of the thread handle, we're also not supposed to return
ERR_NOT_AUTHORIZED here.
 2018-10-24 14:10:48 -04:00
Lioncash
c7c346a15d kernel/error: Add error code for invalid pointers 
The kernel appears to return 0xE601 for this situation. Particularly in
svcWaitSynchronization, svcReplyAndReceive, and svcGetThreadContext
 2018-10-24 13:41:32 -04:00
Lioncash
6df09f5b76 kernel/error: Add error code for closed sessions 
The kernel appears to return 0xF601 for this case.
 2018-10-24 13:38:39 -04:00
Lioncash
4a31f99a02 profile_manager: Use std::optional instead of boost::optional 
Now that we can actually use std::optional on macOS, we don't need to
continue using boost::optional here.
 2018-10-24 11:06:52 -04:00
Lioncash
bed2d6c425 yuzu/main: Notify user of loading errors with Amiibo data 
We shouldn't silently continue if loading failed, since the general
assumption is that no messages showing up implicitly indicates success.
 2018-10-24 10:39:31 -04:00
Mat M
77e705a8fa
Merge pull request #1468 from DarkLordZach/profile-manager-ui 
qt: Add UI to manage emulated user profiles
 2018-10-24 10:10:29 -04:00
Lioncash
93596d03ec
npad: Remove unused controller variable from OnInit() 
This also gets rid of variable shadowing related to the lambda parameter
a little bit below this code as well.
 2018-10-24 00:38:03 -04:00
Lioncash
7c9f7aeacc
perf_stats: Remove unused variable within DoFrameLimiting() 
This hasn't been used since ba8ff096fd
 2018-10-24 00:33:26 -04:00
Lioncash
a3d1ede25f
aoc_u: Make use of previously-unused CheckAOCTitleIDMatchesBase() function 
We can just call the function instead of duplicating the code here. This
also prevents an unused function warning.

We also don't need to take the lambda capture by reference. It's just a
u64 value, so by value is fine here.
 2018-10-24 00:13:08 -04:00
Lioncash
c7c594a6b8
vfs: Handle failure of file reading within VfsRawCopy() 
Also gets rid of an unused variable.
 2018-10-24 00:01:32 -04:00
Lioncash
c6529688fc
key_manager: Remove unused variable in DeriveBase() 2018-10-24 00:00:12 -04:00
bunnei
a94e5d9e68
Merge pull request #1551 from ogniK5377/improved-svcbreak 
Added break types to svcBreak
 2018-10-23 19:56:42 -04:00
Zach Hilman
bfad41b0c1 profile_manager: Create save data if it doesn't exist on use 2018-10-23 19:31:28 -04:00
Zach Hilman
45f2a2fe29 acc: Fix account UUID duplication error 2018-10-23 19:31:28 -04:00
Zach Hilman
e408bbceed configure_system: Clear selection after user delete 2018-10-23 19:31:28 -04:00
Zach Hilman
702622b8f1 profile_manager: Load user icons, names, and UUIDs from system save 2018-10-23 19:31:28 -04:00
Zach Hilman
19c5cf9c63 acc: Load user images from config dir 2018-10-23 19:31:28 -04:00
Zach Hilman
d3fbf45705 am: Pass current user UUID to launch parameters 2018-10-23 19:31:28 -04:00
Zach Hilman
aeffd4b436 profile_manager: Load users from emulator settings 2018-10-23 19:31:28 -04:00
Zach Hilman
e7e3d5898e settings: Add users and current_user settings and remove username 2018-10-23 19:31:28 -04:00
David
50e4e81fd3 Added Amiibo support (#1390) 
* Fixed conflict with nfp

* Few fixups for nfc

* Conflict 2

* Fixed AttachAvailabilityChangeEvent

* Conflict 3

* Fixed byte padding

* Refactored amiibo to not reside in "System"

* Removed remaining references of nfc from system

* used enum for Nfc GetStateOld

* Added missing newline

* Moved file operations to front end

* Conflict 4

* Amiibos now use structs and added mutexes

* Removed amiibo_path
 2018-10-23 19:28:17 -04:00
bunnei
5edb2403c2
Merge pull request #1515 from DarkLordZach/dlc-lfs 
patch_manager: Add support for LayeredFS on DLC RomFS
 2018-10-23 19:26:57 -04:00
bunnei
e61a62066a
Merge pull request #1540 from lioncash/handle 
kernel/process: Make the handle table per-process
 2018-10-23 18:43:11 -04:00
David Marcec
38cdb6744d Added assertion failed, reworked logging levels 2018-10-23 15:17:13 +11:00
David Marcec
8042731da9 Added break types to svcBreak 
There seems to be more such as type 1, and 2. Unsure what these currently are but when a game hits them we can investigate and add the rest
 2018-10-23 15:03:59 +11:00
bunnei
ff6b2d4574
Merge pull request #1545 from DarkLordZach/psm 
psm: Add psm service and stub commands 0 and 1
 2018-10-22 15:27:05 -04:00
bunnei
d9923b0dbc
Merge pull request #1538 from lioncash/query 
svc: Fix vma boundary check in svcQueryMemory
 2018-10-22 12:55:36 -04:00
Zach Hilman
314a948373 psm: Stub GetChargerType 
Used by LovePotion Lua Homebrew. Stubbed as connected to official Nintendo Switch dock.
 2018-10-21 22:03:25 -04:00
Lioncash
ca5a93167e service: Add the basic skeleton for the NPNS services 2018-10-21 17:11:05 -04:00
Lioncash
981faea4d6 hid: Update service function table for hidbus 
Updated based off information provided by Switchbrew.
 2018-10-21 16:51:46 -04:00
Lioncash
5ea4cfd499 am: Add the basic skeleton for the tcap service 
Added based off information provided by Switchbrew.
 2018-10-21 16:50:17 -04:00
Lioncash
edb1c36a87 am: Update service function tables 
Updated based off information from Switchbrew
 2018-10-21 16:40:20 -04:00
Lioncash
ae7f55947e prepo: Update service function table. 
Also introduces the new prepo:a2 service.

Updated based off information provided by Switchbrew.
 2018-10-21 16:22:10 -04:00
Lioncash
a806c78a1a lbl: Update service function table names 
Updated based off information provided by Switchbrew.
 2018-10-21 16:15:32 -04:00
Zach Hilman
10a2d20e26 psm: Stub GetBatteryChargePercentage 
Used by LovePotion Lua Homebrew. Stubbed to return 100% charge.
 2018-10-20 18:01:11 -04:00
Zach Hilman
3b8c0f8885 service: Add skeleton for psm service 
Seems to be the power controller. Listed in switchbrew under the category PTM services.
 2018-10-20 18:01:07 -04:00
Lioncash
90a981a03a kernel/process: Make the handle table per-process 
In the kernel, there isn't a singular handle table that everything gets
tossed into or used, rather, each process gets its own handle table that
it uses. This currently isn't an issue for us, since we only execute one
process at the moment, but we may as well get this out of the way so
it's not a headache later on.
 2018-10-20 16:38:32 -04:00
Lioncash
896c0f61a0 svc: Fix vma boundary check in svcQueryMemory 
This should be comparing against the queried process' vma_map, not the
current process'. The only reason this hasn't become an issue yet is we
currently only handle one process being active at any time.
 2018-10-20 14:56:51 -04:00
David Marcec
a03600ba28 Added auto controller switching to supported controllers and single joycon button rotation 
This is a subset of the better-hid-2 changes, this fixes input in various games which don't support dual joycons. This pr will search for the next best controller which is supported by the current game
 2018-10-20 15:07:18 +11:00
bunnei
60317e6306
Merge pull request #1520 from lioncash/san 
svc: Add missing sanitizing checks for MapSharedMemory/UnmapSharedMemory
 2018-10-19 22:58:57 -04:00
bunnei
bf66930fb9
Merge pull request #1526 from lioncash/svc-id 
service: Update function tables
 2018-10-19 22:53:26 -04:00
bunnei
52b25e0fb9
Merge pull request #1530 from DarkLordZach/aoc-8 
aoc_u: Stub GetAddOnContentListChangedEvent
 2018-10-19 22:53:00 -04:00
bunnei
298ebf444f
Merge pull request #1516 from lioncash/hid 
hid: Minor cleanup-related changes
 2018-10-19 22:52:31 -04:00
Zach Hilman
7e0d2fc994 aoc_u: Stub GetAddOnContentListChangedEvent 
This event signals the game when new DLC is purchased from the eShop while the game is running. Since, for the forseeable future, yuzu will not have this ability, it seems safe to stub with a dummy event that will never fire. This is needed to boot Sonic Mania Plus (update v1.04).
 2018-10-19 21:21:37 -04:00
Zach Hilman
0aef2b9c26 crypto: Use compressed sizes in offset calculation for KIP decompression 
Fixes a fatal crash on start when deriving keys.
 2018-10-19 18:37:58 -04:00
Zach Hilman
a25d79cfaa vfs: Remove InterpretAsDirectory and related functions 
When writing VFS, it initally seemed useful to include a function to in-place convert container files into directories in one homogenous directory structure, but re-evaluating it now there have been plenty of chances to use it and there has always been a better way. Removing as it is unused and likely will not be used.
 2018-10-19 14:02:07 -04:00
David Marcec
7a7dad05c0 Stubbed home blocking 
Needed by arms due to new hid rework
 2018-10-20 00:01:10 +11:00
Lioncash
1833498617 es: Update service function tables 
Updated based off information provided by Switchbrew.
 2018-10-19 04:12:28 -04:00
Lioncash
a653be3510 audio: Update service function tables 
Updated based off information provided by Switchbrew.
 2018-10-19 04:09:12 -04:00
Lioncash
2b9fd23058 omm: Update service function tables 
Updated based off information provided by Switchbrew.
 2018-10-19 04:04:59 -04:00
Lioncash
4f52800822 nifm: Update service function tables 
Updated based off information provided by switchbrew.
 2018-10-19 04:00:41 -04:00
Lioncash
f6c5a48dd1 hid: Update service function tables 
Updated based off information provided by Switchbrew.
 2018-10-19 03:59:15 -04:00
Lioncash
d0cda7fe40 nim: Add the basic skeleton of the nim:eca service 
Added based off information provided by Switchbrew
 2018-10-19 03:46:18 -04:00
Lioncash
d16bafc99d ns: Update service function table 
Updated based off information provided by Switchbrew.
 2018-10-19 03:41:38 -04:00
Lioncash
a056b284cf set_cal: Update service function table 
Updated based on information from Switchbrew.
 2018-10-19 03:26:56 -04:00
bunnei
fdd82b754a
Merge pull request #1523 from lioncash/lock 
svc: Add missing error checks in svcArbitrateLock/svcArbitrateUnlock
 2018-10-18 21:50:45 -04:00
bunnei
7f152f2273
Merge pull request #1511 from lioncash/content 
content_archive: Minor reorganization changes
 2018-10-18 21:48:09 -04:00
bunnei
e5d428cf1e
Merge pull request #1521 from ogniK5377/imp-mmu 
Used better names for mm:u and fixed a bad stub
 2018-10-18 21:46:59 -04:00
Lioncash
4b5ae8dbaa svc: Check for word alignment of addresses within svcArbitrateLock/svcArbitrateUnlock 
The kernel itself checks whether or not the provided addresses are word
aligned before continuing, so we should be doing the same.
 2018-10-18 13:01:29 -04:00
Lioncash
d27f4a4928 common: Move Is4KBAligned() to alignment.h 
Aligning on 4KB pages isn't a Switch-specific thing, so this can be
moved to common so it can be used with other things as well.
 2018-10-18 12:57:02 -04:00
Lioncash
f109615be0 core: Remove unnecessary assert in ArmInterface() 
CpuCore already does this sort of checking, so we can just call that
instead of duplicating the assertions.
 2018-10-18 12:07:25 -04:00
bunnei
d4ff4152ad
Merge pull request #1510 from lioncash/xci 
XCI: Add function for checking the existence of the program NCA
 2018-10-18 11:51:47 -04:00
David Marcec
98c7a6d622 Used better names for mm:u and fixed bad stub 
InitializeWithId needs to return an id which is a u32 which should be a non zero value
 2018-10-19 01:09:34 +11:00
Lioncash
33830aa65a svc: Add missing sanitizing checks for MapSharedMemory/UnmapSharedMemory 
Now that the changes clarifying the address spaces has been merged, we
can wrap the checks that the kernel performs when mapping shared memory
(and other forms of memory) into its own helper function and then use
those within MapSharedMemory and UnmapSharedMemory to complete the
sanitizing checks that are supposed to be done.
 2018-10-18 02:01:21 -04:00
Lioncash
452aa30cb7 hid/controller: Remove unused header inclusions 
swap.h only needs to be present in the header for the type aliases and
definitions, it's not actually needed in the cpp files though. input.h
is just unused entirely in xpad.h
 2018-10-17 20:52:45 -04:00
Lioncash
7f52dc1790 hid/controller/npad: Remove unused dump_idx member variable 
Given it's unused, we may as well toss it.
 2018-10-17 20:52:45 -04:00
Lioncash
7eb2328d8e hid/controller/npad: Remove unnecessary semicolon from the closing brace of LedPattern's constructor 2018-10-17 20:52:45 -04:00
Lioncash
929ed59f1f hid/controller/npad: Remove #pragma once from the cpp file 
This is only useful in headers.
 2018-10-17 20:52:45 -04:00
Lioncash
aeda743446 hid/controller/npad: Move npad_id_list into the cpp file 
This is just a lookup table, and since it's private, there's nothing
really stateful about it, so we can just move it into the cpp file.
 2018-10-17 20:52:45 -04:00
Lioncash
aeca224890 hid/controller/npad: Remove unnecessary const from void return type 
This literally does nothing.
 2018-10-17 20:52:45 -04:00
Lioncash
46202e984e hid/controller: Default the destructors of all controller types in the cpp file 
These classes are non-trivial and are definitely going to be changed in
the future, so we default these to prevent issues with forward
declarations, and to keep the compiler from inlining tear-down code.
 2018-10-17 20:52:43 -04:00
Lioncash
119b47f366 controller_base: Default the base class constructor and destructor in the cpp file 
The destructor doesn't need to be a pure-virtual function.
 2018-10-17 20:51:54 -04:00
bunnei
7dee60d7d2
Merge pull request #1444 from ogniK5377/better-hid 
"Better Hid" Rework Part 1
 2018-10-17 20:25:17 -04:00
bunnei
f912a82a8e
Merge pull request #1497 from bunnei/flush-framebuffers 
Implement flushing in the rasterizer cache
 2018-10-17 18:40:34 -04:00
bunnei
6e8752881c
Merge pull request #1498 from lioncash/aslr 
svc: Clarify enum values for AddressSpaceBaseAddr and AddressSpaceSize in svcGetInfo()
 2018-10-17 18:31:51 -04:00
Zach Hilman
9d0fb0f815 qt: Add support for dumping a DLC Data RomFS 2018-10-17 18:27:29 -04:00
bunnei
afe22d8405
Merge pull request #1509 from DarkLordZach/device-save-data 
savedata_factory: Add DeviceSaveData and fix TemporaryStorage
 2018-10-17 18:22:05 -04:00
Zach Hilman
59044862a9 registered_cache: Deduplicate results of ListEntry and ListEntryFilter 
Prevents a Entry from appearing in the list twice if the user has it installed in two places (e.g. User NAND and SDMC)
 2018-10-17 14:04:18 -04:00
David Marcec
8144fa42bd Using dual joycons as the default controller 
Reason for the change is to allow both docked and undocked mode to work
 2018-10-18 00:11:47 +11:00
Zach Hilman
780c21ab2d fsp_srv: Apply patches to Data storage in OpenDataStorageByDataId 2018-10-17 09:04:20 -04:00
Zach Hilman
d8273c3857 patch_manager: Add support for using LayeredFS with Data 2018-10-17 09:03:56 -04:00
bunnei
ee7c2dbf5a config: Rename use_accurate_framebuffers -> use_accurate_gpu_emulation. 
- This will be used as a catch-all for slow-but-accurate GPU emulation paths.
 2018-10-16 17:02:29 -04:00
Lioncash
871350ae35 content_archive: Simpify assignment of bktr_base_romfs in the constructor 
std::move doesn't actually dereference the data, so it doesn't matter
whether or not the type is null.
 2018-10-16 13:22:31 -04:00
Lioncash
441b5b97bd content_archive: Make IsValidNCA() an internally linked function 
This is only ever used within the cpp file, so it can just be an
internal function.
 2018-10-16 13:22:31 -04:00
Lioncash
53e77ffbfe content_archive: Simplify rights ID check 
This is the same as using std::any_of with an inverted predicate.
 2018-10-16 13:22:31 -04:00
Lioncash
d6604fa765 content_archive: Split loading into separate functions 
The constructor alone is pretty large, the reading code should be split
into its consistuent parts to make it easier to understand it without
having to build a mental model of a 300+ line function.
 2018-10-16 13:22:28 -04:00
Lioncash
4783ad54de content_archive: Pass and take NCASectionHeader instance by reference 
Each header is 512 bytes in size, which is kind of an excessive amount
to copy all the time when it's possible to avoid doing so.
 2018-10-16 12:08:17 -04:00
Lioncash
73e1e929a2 XCI: Add function for checking the existence of the program NCA 
The only reason the getter existed was to check whether or not the
program NCA was null. Instead, we can just provide a function to query
for the existence of it, instead of exposing it entirely.
 2018-10-16 11:36:58 -04:00
bunnei
78f2a6a9e1
Merge pull request #1443 from DarkLordZach/lower-loader-logs-1 
content_archive/patch_manager: Lower log levels to eliminate some unnecessary logs
 2018-10-16 11:26:54 -04:00
David
92d8ad3770 Implement VI ConvertScalingMode (#1475) 
* Implement VI ConvertScalingMode

* Fixed push enum

* Scale mode now uses Nintendo scale mode as an enum as well
 2018-10-16 11:25:42 -04:00
bunnei
88b8383da2
Merge pull request #1502 from lioncash/unique 
core: Convert shared_ptr instances into unique_ptr instances where applicable for System and Cpu
 2018-10-16 11:21:42 -04:00
Zach Hilman
9d4e6176eb savedata_factory: Add TemporaryStorage SaveDataSpaceId 
Required for TemporaryStorage saves (in addition to SaveDataType)
 2018-10-16 10:20:04 -04:00
Zach Hilman
74890cf2da savedata_factory: Add support for DeviceSaveData 
Uses the same path as SaveData except with UID 0. Adds a warning if UID is not 0.
 2018-10-16 10:19:21 -04:00
Lioncash
39ae73b356 file_sys/registered_cache: Use unique_ptr and regular pointers instead of shared_ptrs where applicable 
The data retrieved in these cases are ultimately chiefly owned by either
the RegisteredCache instance itself, or the filesystem factories. Both
these should live throughout the use of their contained data. If they
don't, it should be considered an interface/design issue, and using
shared_ptr instances here would mask that, as the data would always be
prolonged after the main owner's lifetime ended.

This makes the lifetime of the data explicit and makes it harder to
accidentally create cyclic references. It also makes the interface
slightly more flexible than the previous API, as a shared_ptr can be
created from a unique_ptr, but not the other way around, so this allows
for that use-case if it ever becomes necessary in some form.
 2018-10-16 09:38:52 -04:00
bunnei
548958bcaf
Merge pull request #1473 from lioncash/cmake 
web_service: Make linkage of web_service-related externals and the library private
 2018-10-15 21:33:32 -04:00
Lioncash
76fc8b59b2 file_sys/control_metadata: Get rid of magic constants 
These are just the size of the data being passed in, so we can specify
that via the size() member function.
 2018-10-15 20:11:44 -04:00
bunnei
9b21fbd1eb
Merge pull request #1494 from DarkLordZach/aoc-signature-fixes 
aoc: Fix various bugs in current AOC implementation
 2018-10-15 18:34:02 -04:00
bunnei
50e6205c21
Merge pull request #1499 from lioncash/nro 
nro/nso: Minor error handling changes
 2018-10-15 17:48:36 -04:00
Lioncash
bed872ed38 nso: Return an optional address from LoadModule 
If a malformed NSO is attempted to be loaded, we shouldn't continue
onwards. We should be reporting an error and bailing out.
 2018-10-15 17:02:11 -04:00
Lioncash
5484742fda core_cpu: Make Cpu scheduler instances unique_ptrs instead of shared_ptrs 2018-10-15 14:15:56 -04:00
Lioncash
59f872a8e0 core: Make the live Cpu instances unique_ptrs instead of shared_ptrs 
There's no need for shared ownership here, as the only owning class
instance of those Cpu instances is the System class itself. We can also
make the thread_to_cpu map use regular pointers instead of shared_ptrs,
given that the Cpu instances will always outlive the cases where they're
used with that map.
 2018-10-15 14:15:56 -04:00
Lioncash
aeadbfa790 core: Make the exclusive monitor a unique_ptr instead of a shared_ptr 
Like the barrier, this is owned entirely by the System and will always
outlive the encompassing state, so shared ownership semantics aren't
necessary here.
 2018-10-15 14:15:50 -04:00
Lioncash
c34efbbd60 core: Make CPUBarrier a unique_ptr instead of a shared_ptr 
This will always outlive the Cpu instances, since it's destroyed after
we destroy the Cpu instances on shutdown, so there's no need for shared
ownership semantics here.
 2018-10-15 09:11:47 -04:00
Zach Hilman
720d36ca71 crypto: Various crypto fixes for quickstart guide 2018-10-14 21:57:52 -04:00
Lioncash
bb9cf8a127 nso: Make LoadModule take a VfsFile by const reference 2018-10-14 20:38:19 -04:00
Lioncash
0732786ddc nro: Make LoadNro take a VfsFile by const reference 
This function doesn't need to care about ownership semantics, so we can
just pass it a reference to the file itself, rather than a
std::shared_ptr alias.
 2018-10-14 20:24:18 -04:00
Lioncash
90f8474fc1 svc: Clarify enum values for AddressSpaceBaseAddr and AddressSpaceSize in svcGetInfo() 
So, one thing that's puzzled me is why the kernel seemed to *not* use
the direct code address ranges in some cases for some service functions.
For example, in svcMapMemory, the full address space width is compared
against for validity, but for svcMapSharedMemory, it compares against
0xFFE00000, 0xFF8000000, and 0x7FF8000000 as upper bounds, and uses
either 0x200000 or 0x8000000 as the lower-bounds as the beginning of the
compared range. Coincidentally, these exact same values are also used in
svcGetInfo, and also when initializing the user address space, so this
is actually retrieving the ASLR extents, not the extents of the address
space in general.
 2018-10-14 20:11:16 -04:00
Zach Hilman
5737441374 aoc: Read DLC base title ID from RegisteredCache 
Falls back to title ID + 0x1000, which is what HOS does.
 2018-10-14 18:58:14 -04:00
bunnei
b3cca34f50
Merge pull request #1486 from lioncash/file 
key_manager/partition_data_manager: Minor changes
 2018-10-14 14:46:47 -04:00
bunnei
0d2ba0a320
Merge pull request #1491 from lioncash/reference 
filesystem: Make CreateFactories() and InstallInterface() take a VfsFilesystem by reference
 2018-10-14 14:42:57 -04:00
bunnei
2f8ca32020
Merge pull request #1492 from lioncash/proc 
svc: Implement svcGetProcessInfo
 2018-10-14 14:37:58 -04:00
David Marcec
92fae7e1ab Stop all threads on svcBreak 
This should help diagnose crashes easier and prevent many users thinking that a game is still running when in fact it's just an audio thread still running(this is typically not killed when svcBreak is hit since the game expects us to do this)
 2018-10-14 18:14:51 +11:00
Zach Hilman
7e2096db8a aoc: Return size in ListAddOnContent 2018-10-13 22:52:54 -04:00
Lioncash
1c7a7ed79b svc: Implement svcGetProcessInfo 
A fairly basic service function, which only appears to currently support
retrieving the process state. This also alters the ProcessStatus enum to
contain all of the values that a kernel process seems to be able of
reporting with regards to state.
 2018-10-13 17:00:43 -04:00
Lioncash
0149162dba filesystem: Make CreateFactories() and InstallInterface() take a VfsFilesystem instance by reference 
Neither of these functions alter the ownership of the provided pointer,
so we can simply make the parameters a reference rather than a direct
shared pointer alias. This way we also disallow passing incorrect memory values like
nullptr.
 2018-10-13 11:36:35 -04:00
Lioncash
6467b01de2 partition_data_manager: Reserve and insert data within output vector in DecryptPackage2() 
We can just reserve the memory then perform successive insertions
instead of needing to use memcpy. This also avoids the need to zero out
the output vector's memory before performing the insertions.

We can also std::move the output std::vector into the destination so
that we don't need to make a completely new copy of the vector, getting
rid of an unnecessary allocation.

Additionally, we can use iterators to determine the beginning and end
ranges of the std::vector instances that comprise the output vector, as
the end of one range just becomes the beginning for the next successive
range, and since std::vector's iterator constructor copies data within
the range [begin, end), this is more straightforward and gets rid of the
need to have an offset variable that keeps getting incremented to
determine where to do the next std::memcpy.
 2018-10-13 09:50:08 -04:00
Lioncash
781fd7983c partition_data_manager: Remove unused std::map instance within DecryptPackage2() 
Aside from emplacing elements into the map, the map itself is never
actually queried for contained data.
 2018-10-13 09:27:12 -04:00
Lioncash
e0c76226ad partition_data_manager: Take package2_keys by const reference 
These are only ever read from, so we don't need to make a copy of all
the keys here.
 2018-10-13 09:24:41 -04:00
Lioncash
3d9df49619 partition_data_manager: Move IV data to where it's needed in DecryptPackage2() 
Given it's only used in one spot and has a fairly generic name, we can
just specify it directly in the function call. This also the benefit of
automatically moving it.
 2018-10-13 09:20:21 -04:00
Lioncash
bc2196bb09 partition_data_manager: Remove commented out code 
Commented out code shouldn't be left in without a reason indicating why
in a comment.
 2018-10-13 09:17:02 -04:00
Lioncash
6da2ed4232 key_manager/partition_data_manager: Silence truncation compiler warnings 2018-10-13 09:13:19 -04:00
Lioncash
f56a8da46a partition_data_manager: Dehardcode array bounds 
Instead, we can make it part of the type and make named variables for
them, so they only require one definition (and if they ever change for
whatever reason, they only need to be changed in one spot).
 2018-10-13 08:52:37 -04:00
Lioncash
d257a3b56c partition_data_manager: Take VirtualFile by const reference in constructor 
Given the VirtualFile instance isn't stored into the class as a data
member, or written to, this can just be turned into a const reference,
as the constructor doesn't need to make a copy of it.
 2018-10-13 08:39:05 -04:00
Lioncash
e96d69c328 partition_data_manager: Amend constructor initializer list order 
Orders the members in the exact order they would be initialized. This
also prevents compiler warnings about this sort of thing.
 2018-10-13 08:36:26 -04:00
Lioncash
aaca7543f0 partition_data_manager: Remove unused includes 
Gets unused includes out of the headers and moves them into the cpp file
if they're used there instead.
 2018-10-13 08:33:49 -04:00
Lioncash
06898263f6 key_manager: Use std::vector's insert() instead of std::copy with a back_inserter 
If the data is unconditionally being appended to the back of a
std::vector, we can just directly insert it there without the need to
insert all of the elements one-by-one with a std::back_inserter.
 2018-10-13 08:29:35 -04:00
Lioncash
e70c08b543 key_manager: Brace long conditional body 
If a conditional (or it's body) travels more than one line, it should be
braced.
 2018-10-13 08:24:21 -04:00
Lioncash
ef5639bfbb key_manager: Don't assume file seeks and reads will always succeed 
Given the filesystem should always be assumed to be volatile, we should
check and bail out if a seek operation isn't successful. This'll prevent
potentially writing/returning garbage data from the function in rare
cases.

This also allows removing a check to see if an offset is within the
bounds of a file before perfoming a seek operation. If a seek is
attempted beyond the end of a file, it will fail, so this essentially
combines two checks into one in one place.
 2018-10-13 08:24:18 -04:00
Lioncash
82ea1cf35a key_manager: Remove unnecessary seek in DeriveSDSeed() 
Given the file is opened a few lines above and no operations are done,
other than check if the file is in a valid state, the read/write pointer
will always be at the beginning of the file.
 2018-10-13 08:08:44 -04:00
Zach Hilman
f61379f8d2 patch_manager: Move non-Program RomFS patch log to Debug 
Normal Program-type patches will still be logged to aid in debugging, but for others (mainly Control), it was moved to Debug.
 2018-10-12 23:27:19 -04:00
Zach Hilman
90c07e0d33 content_archive: Move get key log to Trace level 
Avoids printing live keys in the general log.
 2018-10-12 23:25:59 -04:00
bunnei
1584fb6b38
Merge pull request #1409 from DarkLordZach/key-derivation 
crypto: Add support for full key derivation
 2018-10-12 22:55:49 -04:00
bunnei
c2aa4293ec
Merge pull request #1483 from lioncash/codeset 
kernel/process: Make CodeSet a regular non-inherited object
 2018-10-12 22:52:12 -04:00
bunnei
ffcda6c08e
Merge pull request #1481 from lioncash/typo 
svc: Fix typos in sanitizing checks for MapMemory/UnmapMemory
 2018-10-12 20:46:55 -04:00
bunnei
2946d4bdbe
Merge pull request #1467 from ogniK5377/svcbreak-type-fix 
Fixed incorrect types for svcBreak
 2018-10-12 12:08:08 -04:00
Lioncash
1abed2f4c4 kernel/process: Make CodeSet a regular non-inherited object 
These only exist to ferry data into a Process instance and end up going
out of scope quite early. Because of this, we can just make it a plain
struct for holding things and just std::move it into the relevant
function. There's no need to make this inherit from the kernel's Object
type.
 2018-10-12 12:07:32 -04:00
bunnei
0f7ab3e21a
Merge pull request #1478 from ogniK5377/remap-invalidhandle-remap 
Passing an invalid nmap handle to Remap should throw an error
 2018-10-12 12:07:14 -04:00
bunnei
f9d03b1d41
Merge pull request #1482 from lioncash/init 
thread: Remove unnecessary memset from ResetThreadContext()
 2018-10-12 12:06:51 -04:00
bunnei
dc328440c8
Merge pull request #1479 from ogniK5377/nmap-revamped 
Added error codes for nvmap
 2018-10-12 12:06:22 -04:00
Lioncash
b492d43e63 thread: Remove unnecessary memset from ResetThreadContext() 
Regular value initialization is adequate here for zeroing out data. It
also has the benefit of not invoking undefined behavior if a non-trivial
type is ever added to the struct for whatever reason.
 2018-10-12 10:57:31 -04:00
David Marcec
4d2de6564f Returned an error before processing other remaps 2018-10-12 17:10:41 +11:00
David Marcec
c55b5de0fb Made the minimum alignment more clear 2018-10-12 17:06:46 +11:00
Lioncash
4ccf30dfaa svc: Fix typos in sanitizing checks for MapMemory/UnmapMemory 2018-10-12 01:48:26 -04:00
David Marcec
98b760c645 Wip 2018-10-12 16:28:00 +11:00
bunnei
9bf409f275
Merge pull request #1474 from ogniK5377/hwopus-decodeinterleavedwithperformance 
HwOpus, Implemented DecodeInterleavedWithPerformance
 2018-10-11 16:52:13 -04:00
bunnei
3fd26b7147
Merge pull request #1472 from lioncash/san 
svc: Add missing address range sanitizing checks to MapMemory/UnmapMemory
 2018-10-11 16:51:41 -04:00
David Marcec
85b0d9a7be Dynamically decide handheld variant based on supported npad id priority 
Kirby input still doesn't work, should fix a lot of other games
 2018-10-12 02:56:49 +11:00
David Marcec
c7763603ef Added error codes for nvmap 2018-10-11 23:06:34 +11:00
David Marcec
5dd538cace Passing an invalid nmap handle to Remap should throw an error 
Added error for invalid nmap handles
 2018-10-11 20:32:21 +11:00
bunnei
bf795edac4 nvhost_as_gpu: Flush CPU VAddr on UnmapBuffer. 2018-10-11 00:19:36 -04:00
Lioncash
28ec921d0d core/CMakeLists: Make all web_service-related libraries private 
Now that all external dependencies are hidden, we can remove
json-headers from the publically linked libraries, as the use of this
library is now completely hidden from external users of the web_service
library. We can also make the web_services library private as well,
considering it's not a requirement. If a library needs to link in
web_service, it should be done explicitly -- not via indirect linking.
 2018-10-10 22:29:39 -04:00
David Marcec
fa10905e1e HwOpus, Implemented DecodeInterleavedWithPerformance 
Used by sonic ages
 2018-10-11 13:06:56 +11:00
Lioncash
6e6ce2ce39 core/CMakeLists: Use target_compile_definitions instead of add_definitions for specifying ENABLE_WEB_SERVICE 
Avoids introducing the definition to the whole directory space and
localizes it to being added to the library that needs it.
 2018-10-10 20:54:02 -04:00
Lioncash
72e9cb523e svc: Add missing address range sanitizing checks to MapMemory/UnmapMemory 
This adds the missing address range checking that the service functions
do before attempting to map or unmap memory. Given that both service
functions perform the same set of checks in the same order, we can wrap
these into a function and just call it from both functions, which
deduplicates a little bit of code.
 2018-10-10 20:30:49 -04:00
David Marcec
9e924f2ef2 Added BeginPermitVibrationSession and EndPermitVibrationSession 
Used by Mario Party
 2018-10-11 00:58:47 +11:00
David Marcec
3d75c9cd7a Added GetLedPattern and HandheldVariant 
HandheldVariant is for specific games which expect handheld controllers to be at position 8(kirby), however this doesn't fix all games as some games require handhelds to be at position 0(snipperclips)
 2018-10-10 21:38:43 +11:00
Lioncash
5c0408596f kernel/thread: Use a regular pointer for the owner/current process 
There's no real need to use a shared pointer in these cases, and only
makes object management more fragile in terms of how easy it would be to
introduce cycles. Instead, just do the simple thing of using a regular
pointer. Much of this is just a hold-over from citra anyways.

It also doesn't make sense from a behavioral point of view for a
process' thread to prolong the lifetime of the process itself (the
process is supposed to own the thread, not the other way around).
 2018-10-10 02:04:55 -04:00
David Marcec
46cdeb4549 Kirby expects handheld controllers to be at position 8 2018-10-10 14:21:56 +11:00
bunnei
5461b21c7a
Merge pull request #1461 from lioncash/warn 
ips_layer: Silence truncation and conversion warnings
 2018-10-09 22:30:01 -04:00
bunnei
3ac874c32e
Merge pull request #1464 from lioncash/unique 
patch_manager: Return a std::unique_ptr from ParseControlNCA() and GetControlMetadata() instead of a std::shared_ptr
 2018-10-09 22:29:39 -04:00
David Marcec
f43815af5d Added the ability to "disconnect" individual npads 
Fixes arms
 2018-10-10 13:15:39 +11:00
David Marcec
b79c294c02 Removed unneeded forward declarations 2018-10-10 13:15:37 +11:00
David Marcec
5857aea94e Addressed changes for better hid 2018-10-10 13:15:37 +11:00
David Marcec
56f35ab262 "Better Hid" rework part 1 2018-10-10 13:15:35 +11:00
David Marcec
2db37ddea9 Changed all casts in svc_wrap.h to be static_cast instead 2018-10-10 12:49:08 +11:00
David Marcec
09b6dda8f0 Use a better name than "dont_kill_application" 
signal_debugger seems like a more fitting name
 2018-10-10 12:27:44 +11:00
David Marcec
a4412c8e22 Fixed incorrect types for svcBreak 
svcBreak reason should be a u32, not a u64.
 2018-10-10 12:23:50 +11:00
bunnei
fe16905de1
Merge pull request #1459 from ogniK5377/break 
svcBreak, Signalling to the debugger should not kill execution
 2018-10-09 16:57:37 -04:00
bunnei
89939be9e6
Merge pull request #1465 from lioncash/telemetry 
telemetry_session: Minor miscellaneous changes
 2018-10-09 16:56:56 -04:00
Lioncash
e3b4d31f4e telemetry_session: Remove doxygen comment for a non-existent parameter 
There's no "func" parameter, so this can just be removed.
 2018-10-09 14:52:10 -04:00
Lioncash
8aa4889e76 telemetry_session: Add missing includes 
Prevents potential compilation issues in the future by including missing
headers for certain functions and types.
 2018-10-09 14:51:39 -04:00
Lioncash
1964f4bbb3 telemetry_session: Remove unimplemented FinalizeAsyncJob prototype 
This isn't implemented anywhere, so it can just be removed.
 2018-10-09 14:46:31 -04:00
Lioncash
8723cc8798 telemetry_session: Use a std::array in GenerateTelemetryId() 
We don't need to potentially heap-allocate a std::string instance here,
given the data is known ahead of time. We can just place it within an
array and pass this to the mbedtls functions.
 2018-10-09 14:46:26 -04:00
Lioncash
6636f3ff47 patch_manager: Return a std::unique_ptr from ParseControlNCA() and GetControlMetadata() instead of a std::shared_ptr 
Neither of these functions require the use of shared ownership of the
returned pointer. This makes it more difficult to create reference
cycles with, and makes the interface more generic, as std::shared_ptr
instances can be created from a std::unique_ptr, but the vice-versa
isn't possible. This also alters relevant functions to take NCA
arguments by const reference rather than a const reference to a
std::shared_ptr. These functions don't alter the ownership of the memory
used by the NCA instance, so we can make the interface more generic by
not assuming anything about the type of smart pointer the NCA is
contained within and make it the caller's responsibility to ensure the
supplied NCA is valid.
 2018-10-09 14:38:03 -04:00
Lioncash
465175cdf5 ips_layer: Avoid constructing std::vector instances where not necessary 
We can just compare the existing std::vector instance with a constexpr
std::array containing the desired match. This is lighter resource-wise,
as we don't need to allocate on the heap.
 2018-10-09 14:10:22 -04:00
Lioncash
9ff743bc0a ips_layer: Remove unnecessary explicit std::pair constructor in std::array 
Makes the layout of the array consistent, by making all elements match,
instead of special-casing the first one.
 2018-10-09 14:10:22 -04:00
Lioncash
f7d2889fb4 ips_layer: Add missing includes 
Adds missing includes to prevent potential compilation issues in the
future. Also moves the definition of a struct into the cpp file, so that
some includes don't need to be introduced within the header.
 2018-10-09 14:10:13 -04:00
Lioncash
93ac8d0fea ips_layer: std::move data within PatchIPS() and Apply() 
We don't need to make a copy of the read data, so we can std::move it
into the make_shared call here.
 2018-10-09 14:06:44 -04:00
Lioncash
567e818440 ips_layer: Silence truncation and conversion warnings 
Makes type conversions explicit to avoid compiler warnings.
 2018-10-09 13:18:23 -04:00
David Marcec
f5631e78d1 Added bitfield instead of manually checking if the bit is set 2018-10-09 12:11:14 +11:00
David Marcec
af3ba94b2a Actual kill execution when the bit isn't set, not the other way around 2018-10-09 11:14:48 +11:00
David Marcec
c50f66a8eb svcBreak, Signalling to the debugger should not kill execution 
When loading NROs, svcBreak is called to signal to the debugger that a new "module" is loaded. As no debugger is technically attached we shouldn't be killing the programs execution.
 2018-10-09 11:10:30 +11:00
bunnei
561d79e034
Merge pull request #1423 from DarkLordZach/romfs-file-exts 
fsmitm_romfsbuild: Add support for stubbing and IPS patches in LFS
 2018-10-08 12:31:27 -04:00
bunnei
6b48ba5271
Merge pull request #1424 from DarkLordZach/ips-witch 
ips_layer: Add support for IPSwitch executable patches
 2018-10-08 12:30:33 -04:00
bunnei
fd891ee9c0
Merge pull request #1456 from ogniK5377/aoc-u-fixups 
Fixed assertion due to CountAddOnContent & Casting warnings
 2018-10-08 01:21:05 -04:00
bunnei
3f1f82a8c4
Merge pull request #1457 from ogniK5377/unmap-buffer 
Unmapping an unmapped buffer should succeed
 2018-10-08 01:20:18 -04:00
David Marcec
c5c184246d Unmapping an unmapped buffer should succeed 
Hardware tests show that trying to unmap an unmapped buffer already should always succeed. Hardware test was tested up to 32 iterations of attempting to unmap
 2018-10-08 13:26:48 +11:00
Zach Hilman
f945e9767c nso/nro: Use default allocation size for arg_data 2018-10-07 14:32:33 -04:00
Zach Hilman
081f5c1dbf cmd: Support passing game arguments from command line 
Uses -p (--program) and following string as args.
 2018-10-07 14:32:32 -04:00
Zach Hilman
95dff555a4 settings: Add program_args string setting 2018-10-07 14:32:05 -04:00
Zach Hilman
e09505ff61 nso/nro: Add NSO arguments structure to data section 
Only added if arguments string is non-empty and a pass is requested by loader.
 2018-10-07 14:30:15 -04:00
Zach Hilman
3ec054643e partition_data_manager: Rename system files for hekate 
x
 2018-10-07 13:16:23 -04:00
Zach Hilman
29dc6f4519 crypto: Add PartitionDataManager 
Keeps track of system files for key derivation
 2018-10-07 13:15:11 -04:00
Zach Hilman
4aad010f7a key_manager: Add support for loading keys from partition data 2018-10-07 13:15:11 -04:00
Zach Hilman
d041d6231c key_manager: Add ETicket key derivation 
Derives titlekeys
 2018-10-07 13:15:11 -04:00
Zach Hilman
a57aac5772 key_manager: Add base key derivation 
Derives master keys, game encryption keys, and package1/2 keys
 2018-10-07 13:15:11 -04:00
Zach Hilman
d7398283e3 key_manager: Add BIS key getter 2018-10-07 13:15:11 -04:00
Zach Hilman
d6a0d5d432 key_manager: Add support for more keys 
TSEC, SBK, BIS, and other Sources for proper derivation
 2018-10-07 13:15:11 -04:00
Zach Hilman
c79d2ca6cf key_manager: Add keyblob support 2018-10-07 13:15:11 -04:00
Zach Hilman
e4602748d6 key_manager: Add support for crypto revisions past 04 2018-10-07 13:15:11 -04:00
Zach Hilman
9e34303fb9 key_manager: Add support for comments in keyfiles 2018-10-07 13:15:11 -04:00
Zach Hilman
1fa6ee4723 vfs: Move forward declarations to separate file 2018-10-07 13:15:11 -04:00
Zach Hilman
ce05df0a6d key_manager: Add support for console-specific keyfile 2018-10-07 13:15:11 -04:00
Zach Hilman
721632fe66 key_manager: Rename KEK to Kek 2018-10-07 13:15:11 -04:00
David Marcec
fa3f3cd07f Fixed assertion due to CountAddOnContent 
Word count should be 3 since we're pushing a result code and a u32.

Also fixed up compiler warnings due to casting
 2018-10-08 00:25:46 +11:00
bunnei
6e4d2e672d
Merge pull request #1396 from DarkLordZach/packed-updates 
loader: Add support for packed updates
 2018-10-06 23:58:24 -04:00
bunnei
450c0a5adf
Merge pull request #1448 from ogniK5377/frontend-access 
Ported #4296 from citra
 2018-10-06 22:25:29 -04:00
David Marcec
612ce89eca Added forward define for ServerPort 2018-10-06 17:47:33 +10:00