Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Merge pull request #11529 from lat9nq/no-oob-names-pls

Browse source 
mii_types: Remove null terminator check
This commit is contained in:
Narr the Reg 2023-09-17 14:27:44 -06:00 committed by GitHub
parent 2fe92436b9 77682aabd3
commit e18ff5cb4e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/core/hle/service/mii/mii_types.h
View file

@ -606,15 +606,12 @@ struct Nickname {
static constexpr std::size_t MaxNameSize = 10; static constexpr std::size_t MaxNameSize = 10;
std::array<char16_t, MaxNameSize> data; std::array<char16_t, MaxNameSize> data;
// Checks for null, non-zero terminated or dirty strings // Checks for null or dirty strings
bool IsValid() const { bool IsValid() const {
if (data[0] == 0) { if (data[0] == 0) {
return false; return false;
} }
if (data[MaxNameSize] != 0) {
return false;
}
std::size_t index = 1; std::size_t index = 1;
while (data[index] != 0) { while (data[index] != 0) {
index++; index++;