Mirrors/yuzu
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #4255 from lioncash/copy

Browse source 
configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox()
This commit is contained in:
bunnei 2020-07-08 16:28:10 -04:00 committed by GitHub
commit 9c2773409a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/yuzu/configuration/configure_graphics.cpp
View file

@ -28,9 +28,9 @@ ConfigureGraphics::ConfigureGraphics(QWidget* parent)
SetConfiguration(); SetConfiguration();
connect(ui->api, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged), this, connect(ui->api, qOverload<int>(&QComboBox::currentIndexChanged), this,
[this] { UpdateDeviceComboBox(); }); [this] { UpdateDeviceComboBox(); });
connect(ui->device, static_cast<void (QComboBox::*)(int)>(&QComboBox::activated), this, connect(ui->device, qOverload<int>(&QComboBox::activated), this,
[this](int device) { UpdateDeviceSelection(device); }); [this](int device) { UpdateDeviceSelection(device); });
connect(ui->bg_button, &QPushButton::clicked, this, [this] { connect(ui->bg_button, &QPushButton::clicked, this, [this] {
@ -112,7 +112,7 @@ void ConfigureGraphics::UpdateDeviceComboBox() {
enabled = false; enabled = false;
break; break;
case Settings::RendererBackend::Vulkan: case Settings::RendererBackend::Vulkan:
for (const auto device : vulkan_devices) { for (const auto& device : vulkan_devices) {
ui->device->addItem(device); ui->device->addItem(device);
} }
ui->device->setCurrentIndex(vulkan_device); ui->device->setCurrentIndex(vulkan_device);