Merge pull request #4847 from ReinUsesLisp/warn-move

video_core: Enforce -Wredundant-move and -Wpessimizing-move
This commit is contained in:
LC 2020-10-28 03:14:58 -04:00 committed by GitHub
commit 55ac6f7a2b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 4 deletions

View file

@ -302,6 +302,8 @@ else()
target_compile_options(video_core PRIVATE target_compile_options(video_core PRIVATE
-Werror=conversion -Werror=conversion
-Wno-error=sign-conversion -Wno-error=sign-conversion
-Werror=pessimizing-move
-Werror=redundant-move
-Werror=switch -Werror=switch
-Werror=unused-variable -Werror=unused-variable

View file

@ -366,7 +366,7 @@ Vp9PictureInfo VP9::GetVp9PictureInfo(const NvdecCommon::NvdecRegisters& state)
// to avoid buffering frame data needed for reference frame updating in the header composition. // to avoid buffering frame data needed for reference frame updating in the header composition.
std::memcpy(vp9_info.frame_offsets.data(), state.surface_luma_offset.data(), 4 * sizeof(u64)); std::memcpy(vp9_info.frame_offsets.data(), state.surface_luma_offset.data(), 4 * sizeof(u64));
return std::move(vp9_info); return vp9_info;
} }
void VP9::InsertEntropy(u64 offset, Vp9EntropyProbs& dst) { void VP9::InsertEntropy(u64 offset, Vp9EntropyProbs& dst) {

View file

@ -317,8 +317,7 @@ std::optional<std::vector<ShaderDiskCachePrecompiled>> ShaderDiskCacheOpenGL::Lo
return std::nullopt; return std::nullopt;
} }
} }
return entries;
return std::move(entries);
} }
void ShaderDiskCacheOpenGL::InvalidateTransferable() { void ShaderDiskCacheOpenGL::InvalidateTransferable() {

View file

@ -844,7 +844,7 @@ std::optional<std::vector<VkExtensionProperties>> EnumerateInstanceExtensionProp
VK_SUCCESS) { VK_SUCCESS) {
return std::nullopt; return std::nullopt;
} }
return std::move(properties); return properties;
} }
std::optional<std::vector<VkLayerProperties>> EnumerateInstanceLayerProperties( std::optional<std::vector<VkLayerProperties>> EnumerateInstanceLayerProperties(