mirror of
https://github.com/yuzu-mirror/yuzu.git
synced 2024-07-06 21:06:48 +01:00
2b2dc00bfd
In OnMenuRecentFile() we don't need to construct a QFileInfo instance just to check if a file exists, we can just use the static member function to do that (which Qt's documentation also notes as quicker than constructing an instance). In UpdateUITheme(), we just want to try and open the file and check the success of that operation. Technically speaking, between the existence check and the open call, the file can be deleted or moved, but still appear to succeed in code. i.e. 1. Existence check -> Returns true 2. File is moved/deleted 3. Open is called, the return value of which isn't checked 4. Nonsense behavior This way we combine the existence check and the open into one. |
||
|---|---|---|
| .. | ||
| configuration | ||
| debugger | ||
| util | ||
| about_dialog.cpp | ||
| about_dialog.h | ||
| aboutdialog.ui | ||
| bootmanager.cpp | ||
| bootmanager.h | ||
| CMakeLists.txt | ||
| game_list.cpp | ||
| game_list.h | ||
| game_list_p.h | ||
| hotkeys.cpp | ||
| hotkeys.h | ||
| hotkeys.ui | ||
| Info.plist | ||
| main.cpp | ||
| main.h | ||
| main.ui | ||
| ui_settings.cpp | ||
| ui_settings.h | ||
| yuzu.rc | ||