Liam
985ed1e160
memory: remove DEBUG_ASSERT pointer test
2022-12-10 13:02:38 -05:00
Salvage
c586ac9be2
Remove the lock entirely as per PR discussion
...
Correctly unlock mutex before its destruction
As per https://en.cppreference.com/w/cpp/thread/mutex/~mutex destroying a locked mutex is undefined behavior and MSVC++ decides to throw in this case
Swap out unique for scoped lock and readd comment
2022-12-09 16:39:59 +01:00
Liam
9704acb982
general: improve handling of system startup failure
2022-12-06 16:13:42 -05:00
merry
e1f5f4bdea
Merge pull request #9370 from liamwhite/break-unmapped
...
core: add option to break on unmapped access
2022-12-06 20:20:20 +00:00
liamwhite
4b7e73e0a6
Merge pull request #9392 from lioncash/reporter
...
reporter: Eliminate undefined behavior in SaveErrorReport
2022-12-06 11:27:00 -05:00
liamwhite
d8534ea140
Merge pull request #9390 from lioncash/keyboard
...
applets: Extract callback types into aliases
2022-12-06 11:26:53 -05:00
liamwhite
bbdb6d391e
Merge pull request #9389 from lioncash/emumove
...
emulated_console/emulated_controller: std::move ParamPackage instances where applicable
2022-12-06 11:26:46 -05:00
liamwhite
a86af1b776
Merge pull request #9386 from lioncash/init
...
kernel: Ensure relevant class members are always initialized on construction
2022-12-06 11:26:38 -05:00
liamwhite
04779b3d2a
Merge pull request #9369 from german77/mifare
...
service: nfc: Implement mifare service
2022-12-05 22:17:32 -05:00
Lioncash
eadc1ae1e7
reporter: Pass by const reference where applicable
...
Same behavior, but without memory churn.
2022-12-05 21:48:42 -05:00
Lioncash
e7f9f58fa4
reporter: Eliminate undefined behavior in SaveErrorReport
...
The optionals are unconditionally dereferenced when setting the custom
error text, and in a few cases this function is called using the default
value of the optionals.
This means we'd be dereferencing uninitialized storage.
Since they're used unconditionally, we can use value_or to set a default
when storage is uninitialized.
2022-12-05 21:31:34 -05:00
Lioncash
fedd857054
applets/controller: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
Lioncash
d8da9a2afd
applets/error: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
Lioncash
2b40cdf04f
applets/mii_edit: Use aliases for callbacks
2022-12-05 19:06:04 -05:00
Lioncash
a84676c2aa
applets/profile_select: Use aliases for callbacks
...
Deduplicates callback definitions and situates it in one place.
2022-12-05 19:06:04 -05:00
Lioncash
e26c86a6e7
applets/web_browser: Use aliases for callbacks
...
Deduplicates a lot of long callback declarations
2022-12-05 19:06:04 -05:00
Lioncash
9bbb77637e
applets/software_keyboard: Use aliases for callbacks
...
Deduplicates really long std::function declarations to make the
interface nicer to read.
2022-12-05 19:06:01 -05:00
Lioncash
e4a16f50ef
emulated_controller: Remove unused parameter in GetMappedDevices()
...
This isn't used, so it can be removed to make the function a little
nicer.
2022-12-05 18:27:18 -05:00
Lioncash
87543b9dea
emulated_controller: Use std::move() in GetMappedDevices()
...
Avoids churning allocations in a loop.
2022-12-05 18:27:15 -05:00
Lioncash
7bf4b45349
emulated_console: Amend cast in SetTouch()
...
id is an int value, not a u32.
2022-12-05 18:15:23 -05:00
Lioncash
4255e30722
emulated_console: std::move() ParamPackages and callbacks where applicable
2022-12-05 18:15:19 -05:00
Lioncash
efa8711bf3
kernel/k_shared_memory: Ensure device_memory is always initialized
2022-12-05 15:27:57 -05:00
Lioncash
c3fd211b43
kernel/k_memory_block: Ensure members are always initialized
2022-12-05 15:27:47 -05:00
Lioncash
dcca650599
kernel/physical_core: Ensure is_interrupted is always initialized
2022-12-05 15:19:37 -05:00
Lioncash
dddc9bb8f1
kernel/thread: Ensure stack_top and argument are always initialized
2022-12-05 15:19:36 -05:00
Lioncash
4769d798f9
kernel/kernel: Ensure shutdown threads are always initialized
2022-12-05 15:19:36 -05:00
liamwhite
3b19f741bd
Merge pull request #6833 from abouvier/unbundle
...
cmake: prefer system libraries
2022-12-05 12:26:09 -05:00
Mai
a52d0b82a6
Merge pull request #9381 from liamwhite/uninit
...
service_thread: fix uninitialized memory usage
2022-12-04 22:30:16 +00:00
Liam
cec3a3cd5a
service_thread: fix uninitialized memory usage
2022-12-04 16:02:24 -05:00
liamwhite
3b9db85646
Merge pull request #9232 from bunnei/audio-default-thread
...
hle: service: audio: Use default service thread.
2022-12-04 15:31:40 -05:00
liamwhite
522e7c5663
Merge pull request #9273 from ameerj/per-game-profile
...
Configuration: Add per-game input profiles
2022-12-04 13:38:01 -05:00
Alexandre Bouvier
8e17b5469f
cmake: prefer system libraries
2022-12-04 17:09:25 +01:00
liamwhite
02b10a6e4d
Merge pull request #9374 from liamwhite/externals
...
externals: update dynarmic, SDL2
2022-12-04 10:44:12 -05:00
Liam
6d2c597371
externals: update dynarmic, SDL2
2022-12-04 10:12:26 -05:00
bunnei
f77cc6c412
Merge pull request #9344 from liamwhite/null
...
video_core: add null backend
2022-12-03 11:23:25 -08:00
liamwhite
75e16547f8
Merge pull request #9300 from ameerj/pch
...
CMake: Use precompiled headers to improve compile times
2022-12-03 14:10:06 -05:00
liamwhite
22aff09b33
Merge pull request #9289 from liamwhite/fruit-company
...
general: fix compile for Apple Clang
2022-12-03 12:09:21 -05:00
Matías Locatti
c043ba8467
Merge pull request #9303 from liamwhite/new-vulkan-init
...
Vulkan: update initialization
2022-12-02 18:32:54 -03:00
Liam
6072b22a0b
core: add option to break on unmapped access
2022-12-02 08:25:45 -05:00
liamwhite
d8bd52c6f1
Merge pull request #9348 from Morph1984/when-the-network-is-down
...
service: nifm: Update stubs for Submit/GetRequestState/GetResult
2022-12-01 22:14:43 -05:00
Narr the Reg
a4725bcb73
service: nfc: Implement mifare service
2022-12-01 20:43:59 -06:00
ameerj
5b5612c1cc
CMake: Consolidate common PCH headers
2022-11-30 18:30:30 -05:00
Fernando S
4e89979c87
Merge pull request #9320 from yuzu-emu/fix-audio-suspend
...
AudioCore: Take suspend lock when stalling the running process.
2022-11-30 16:41:32 +01:00
ameerj
37bc5118ea
CMake: Use precompiled headers
2022-11-29 18:50:49 -05:00
liamwhite
55a3cbfa0d
Merge pull request #9340 from lioncash/nvdrv
...
nvdrv: Simplify builder declarations
2022-11-29 08:27:13 -05:00
liamwhite
6b8ab9ed8f
Merge pull request #9346 from lioncash/vtable
...
producer_listener: Add virtual destructor to IProducerListener
2022-11-29 08:26:32 -05:00
liamwhite
a7f1fa7bfc
Merge pull request #9345 from lioncash/fence
...
consumer_base: Pass std::shared_ptr by const reference
2022-11-29 08:26:25 -05:00
liamwhite
b6373c5ea5
Merge pull request #9343 from lioncash/bounds
...
syncpoint_manager: Reduce redundant bounds checks
2022-11-29 08:26:16 -05:00
Morph
00fdffec58
service: nifm: Update stubs for Submit/GetRequestState/GetResult
2022-11-28 22:58:10 -05:00
Liam
89dd7dc180
video_core: add null backend
2022-11-28 19:49:09 -05:00
Lioncash
25dda06f49
producer_listener: Add virtual destructor to IProducerListener
...
Several member variables are shared_ptr's to this base class. Even
though producer listeners are still unimplemented, this ensures we
always have consistent deletion behavior once this ends up being used
polymorphically.
2022-11-28 19:39:13 -05:00
Lioncash
ae74f46e78
buffer_item_consumer: Pass fence by const-ref in ReleaseBuffer()
...
This isn't directly modified.
Also allows rvalues to be used with it.
2022-11-28 19:16:20 -05:00
Lioncash
3020f72b0c
buffer_queue_consumer: std::move std::shared_ptr in Connect()
...
Avoids an unnecessary reference count increment and decrement
2022-11-28 19:12:26 -05:00
Lioncash
c0c4f6dfa6
consumer_base: Pass shared_ptr by const reference
...
Avoids churning atomic reference count increments and decrements.
2022-11-28 19:09:44 -05:00
Lioncash
260a495a23
consumer_base: Remove redundant virtual
...
override already serves this purpose
2022-11-28 19:06:34 -05:00
Lioncash
7a329ae56c
syncpoint_manager: Mark IsSyncpointAllocated() as const
...
This doesn't modify class state at all.
2022-11-28 16:08:21 -05:00
Lioncash
d0883027d6
syncpoint_manager: Reduce number of bounds checks
...
The only time we need to check bounds is on the first access.
2022-11-28 16:06:01 -05:00
Lioncash
ad787b20ca
nvdrv: Simplify builder declarations
...
We can just use auto here. If one of these ever happens to not be
derived from nvdevice, then this will cause a compilation error.
We can also move the devices into the collection to get rid of an
unnecessary atomic reference count increment and decrement.
2022-11-28 10:43:48 -05:00
Lioncash
780ae92265
core/hid/emulated_controller: Use ranges version of transform
...
Makes the transform calls much nicer to read.
2022-11-28 10:00:42 -05:00
Lioncash
2ec7d0b5fd
common/input: Add helpers functions for creating input and output devices
...
Avoids the redundancy of needing to explictly specify the common
namespace and the type.
2022-11-28 10:00:37 -05:00
Liam
2956a33463
Vulkan: update initialization
...
Co-authored-by: bylaws <bylaws@users.noreply.github.com>
2022-11-27 14:58:28 -05:00
german77
a67e776af9
yuzu-cmd: Fix input callback crash on close
2022-11-27 10:53:22 -06:00
Valeri
278c0e6e8d
crypto: use user-provided keys whenever possible
...
Solves an issue where autogenerated title keys would take precedence over those provided by user.
2022-11-27 05:08:25 +03:00
bunnei
8f6245be9a
core: Use atomic instead of a lock to protect is_paused.
...
- This allows us to call IsPaused() elsewhere if we are holding the suspend lock.
2022-11-26 13:46:38 -08:00
Lioncash
97f273e94e
service: Make use of buffer element count helpers
2022-11-23 13:43:20 -05:00
Lioncash
59335f6796
hle_ipc: Add helper functions for getting number of buffer elements
2022-11-23 13:15:19 -05:00
Lioncash
c31f19b6d1
hle_ipc: Mark relevant member functions as [[nodiscard]]
...
Will allow the compiler to complain about cases where ignoring the
return value would be a bug.
2022-11-23 13:08:52 -05:00
Liam
9737615948
general: fix compile for Apple Clang
2022-11-22 22:22:28 -05:00
liamwhite
168c9ee341
Merge pull request #9299 from lioncash/cast
...
k_handle_table: Remove cast to void* in GetObjectForIpc
2022-11-22 17:47:53 -05:00
Lioncash
8d99aae45b
k_handle_table: Remove cast to void* in GetObjectForIpc
...
This was used to get around the KProcess class being incomplete. We can
just move this to the cpp file and eliminate the cast entirely, letting
the compiler do its work.
2022-11-22 13:58:42 -05:00
bunnei
f047f376d4
Merge pull request #9219 from german77/nfc_impl
...
service: nfc: Implement NFC IUser service
2022-11-22 10:28:38 -08:00
ameerj
9efdad6a27
Configuration: Add per-game input profiles
2022-11-20 14:06:31 -05:00
Narr the Reg
db7bcd51ae
Merge branch 'master' into nfc_impl
2022-11-20 09:31:20 -06:00
Liam
eb0713f781
dmnt:cht: fix copy-paste error
2022-11-20 10:14:22 -05:00
bunnei
57a05b1653
Merge pull request #9238 from german77/cabinet_applet
...
service: am: Implement cabinet applet
2022-11-20 00:48:39 -08:00
bunnei
109c31c90f
Merge pull request #9254 from FernandoS27/auto-cpu-fix
...
Dynarmic: Remove inaccurate NaN from Auto CPU settings.
2022-11-19 12:52:41 -08:00
liamwhite
bcbc25eeb3
Merge pull request #9191 from german77/touching_souls
...
core: hid: Implement true multitouch support
2022-11-19 13:21:01 -05:00
Narr the Reg
327d225c3e
service: nfc: Implement nfc user
2022-11-19 08:51:59 -06:00
german77
aa075a0c08
service: hid: Only overclock npad controllers
2022-11-19 08:44:42 -06:00
Narr the Reg
38c48cf8d8
core: hid: Implement true multitouch support
2022-11-19 08:44:33 -06:00
bunnei
1fb33bd1e1
Merge pull request #9234 from liamwhite/data-cash-money
...
kernel: implement data cache management operations
2022-11-18 13:18:36 -08:00
bunnei
405d685101
Merge pull request #9244 from liamwhite/lost-wakeup
...
nvnflinger: fix lost wakeup
2022-11-17 17:15:47 -08:00
Morph
e5a446a0df
Merge pull request #9229 from Docteh/achy_breaky_heart
...
Add break for default cases
2022-11-17 19:20:18 -05:00
Fernando Sahmkow
bc95753107
Dynarmic: Remove inaccurate NaN from Auto CPU settings.
2022-11-17 16:59:41 +01:00
bunnei
9e27624a19
Merge pull request #9243 from german77/result
...
core: Update result module
2022-11-14 20:36:38 -08:00
Liam
cf202f3718
nvnflinger: fix lost wakeup
2022-11-14 21:18:52 -05:00
Narr the Reg
18fcc03b3c
core: Update result module
2022-11-14 20:08:47 -06:00
Kyle Kienapfel
6fa3faec65
Add break for default cases
...
Visual Studio has an option to search all files in a solution, so I
did a search in there for "default:" looking for any missing break
statements.
I've left out default statements that return something, and that throw
something, even if via ThrowInvalidType. UNREACHABLE leads towards throw
R_THROW macro leads towards a return
2022-11-13 16:30:55 -08:00
german77
75e6ec85e1
general: Address review comments
2022-11-13 17:13:43 -06:00
german77
a253d1557d
service: am: Fix cabinet applet result
2022-11-13 14:25:00 -06:00
german77
fb57cd26a1
service: am: Implement cabinet applet backend
2022-11-13 11:07:48 -06:00
german77
6c045c9beb
service: nfc: fix tagprotocol and implement GetApplicationAreaId
2022-11-13 10:52:48 -06:00
liamwhite
040a01a5dd
Merge pull request #9225 from liamwhite/debugger-instance
...
Debugger improvements
2022-11-12 21:04:00 -05:00
Liam
651f6598ac
kernel: implement FlushProcessDataCache
2022-11-12 11:27:04 -05:00
bunnei
b51c1544b9
Merge pull request #9224 from liamwhite/services-arent-processes
...
service_thread: remove explicit KProcess
2022-11-11 22:37:04 -08:00
bunnei
0d6a8824d0
hle: service: audio: Use default service thread.
...
- This was arbitrarily added by me, and does not appear to be helpful.
2022-11-11 17:34:39 -08:00
bunnei
d05b183f21
Merge pull request #9198 from liamwhite/arm64
...
Initial ARM64 support
2022-11-10 17:11:27 -08:00
Liam
18123ff958
gdbstub: add ams monitor commands
2022-11-10 19:20:57 -05:00
Liam
ceb829cc33
debugger: allow more than one connection attempt per session
2022-11-10 17:39:04 -05:00
Liam
b34d3d5882
service_thread: remove explicit KProcess
2022-11-10 16:14:03 -05:00
