CMakeLists: Treat -Wsign-compare as an error on GCC/Clang

Treats (un)signed comparison mismatches as errors to be consistent with MSVC
This commit is contained in:
Morph 2021-07-06 12:48:49 -04:00
parent bf50345d4c
commit ebb82b0b83
4 changed files with 1 additions and 8 deletions

View file

@ -82,6 +82,7 @@ else()
-Werror=missing-declarations -Werror=missing-declarations
-Werror=missing-field-initializers -Werror=missing-field-initializers
-Werror=reorder -Werror=reorder
-Werror=sign-compare
-Werror=switch -Werror=switch
-Werror=uninitialized -Werror=uninitialized
-Werror=unused-function -Werror=unused-function

View file

@ -51,9 +51,6 @@ if (NOT MSVC)
target_compile_options(audio_core PRIVATE target_compile_options(audio_core PRIVATE
-Werror=conversion -Werror=conversion
-Werror=ignored-qualifiers -Werror=ignored-qualifiers
-Werror=implicit-fallthrough
-Werror=reorder
-Werror=sign-compare
-Werror=shadow -Werror=shadow
-Werror=unused-parameter -Werror=unused-parameter
-Werror=unused-variable -Werror=unused-variable

View file

@ -667,8 +667,6 @@ else()
target_compile_options(core PRIVATE target_compile_options(core PRIVATE
-Werror=conversion -Werror=conversion
-Werror=ignored-qualifiers -Werror=ignored-qualifiers
-Werror=implicit-fallthrough
-Werror=sign-compare
-Werror=shadow -Werror=shadow
$<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess> $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess>

View file

@ -44,10 +44,7 @@ else()
-Werror -Werror
-Werror=conversion -Werror=conversion
-Werror=ignored-qualifiers -Werror=ignored-qualifiers
-Werror=implicit-fallthrough
-Werror=reorder
-Werror=shadow -Werror=shadow
-Werror=sign-compare
$<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter> $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-parameter>
$<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-variable> $<$<CXX_COMPILER_ID:GNU>:-Werror=unused-but-set-variable>
-Werror=unused-variable -Werror=unused-variable