Merge pull request #2334 from lioncash/override

core: Add missing override specifiers where applicable
This commit is contained in:
bunnei 2019-04-05 23:39:52 -04:00 committed by GitHub
commit e86b26cd2b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 9 additions and 23 deletions

View file

@ -26,7 +26,6 @@ using Vector = Dynarmic::A64::Vector;
class ARM_Dynarmic_Callbacks : public Dynarmic::A64::UserCallbacks { class ARM_Dynarmic_Callbacks : public Dynarmic::A64::UserCallbacks {
public: public:
explicit ARM_Dynarmic_Callbacks(ARM_Dynarmic& parent) : parent(parent) {} explicit ARM_Dynarmic_Callbacks(ARM_Dynarmic& parent) : parent(parent) {}
~ARM_Dynarmic_Callbacks() = default;
u8 MemoryRead8(u64 vaddr) override { u8 MemoryRead8(u64 vaddr) override {
return Memory::Read8(vaddr); return Memory::Read8(vaddr);

View file

@ -29,7 +29,7 @@ class ARM_Dynarmic final : public ARM_Interface {
public: public:
ARM_Dynarmic(Timing::CoreTiming& core_timing, ExclusiveMonitor& exclusive_monitor, ARM_Dynarmic(Timing::CoreTiming& core_timing, ExclusiveMonitor& exclusive_monitor,
std::size_t core_index); std::size_t core_index);
~ARM_Dynarmic(); ~ARM_Dynarmic() override;
void MapBackingMemory(VAddr address, std::size_t size, u8* memory, void MapBackingMemory(VAddr address, std::size_t size, u8* memory,
Kernel::VMAPermission perms) override; Kernel::VMAPermission perms) override;
@ -76,7 +76,7 @@ private:
class DynarmicExclusiveMonitor final : public ExclusiveMonitor { class DynarmicExclusiveMonitor final : public ExclusiveMonitor {
public: public:
explicit DynarmicExclusiveMonitor(std::size_t core_count); explicit DynarmicExclusiveMonitor(std::size_t core_count);
~DynarmicExclusiveMonitor(); ~DynarmicExclusiveMonitor() override;
void SetExclusive(std::size_t core_index, VAddr addr) override; void SetExclusive(std::size_t core_index, VAddr addr) override;
void ClearExclusive() override; void ClearExclusive() override;

View file

@ -18,7 +18,7 @@ namespace Core {
class ARM_Unicorn final : public ARM_Interface { class ARM_Unicorn final : public ARM_Interface {
public: public:
explicit ARM_Unicorn(Timing::CoreTiming& core_timing); explicit ARM_Unicorn(Timing::CoreTiming& core_timing);
~ARM_Unicorn(); ~ARM_Unicorn() override;
void MapBackingMemory(VAddr address, std::size_t size, u8* memory, void MapBackingMemory(VAddr address, std::size_t size, u8* memory,
Kernel::VMAPermission perms) override; Kernel::VMAPermission perms) override;

View file

@ -2,9 +2,6 @@
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
#include "common/logging/log.h"
#include "core/hle/ipc_helpers.h"
#include "core/hle/kernel/hle_ipc.h"
#include "core/hle/service/audio/audin_u.h" #include "core/hle/service/audio/audin_u.h"
namespace Service::Audio { namespace Service::Audio {
@ -33,7 +30,6 @@ public:
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~IAudioIn() = default;
}; };
AudInU::AudInU() : ServiceFramework("audin:u") { AudInU::AudInU() : ServiceFramework("audin:u") {

View file

@ -2,9 +2,6 @@
// Licensed under GPLv2 or any later version // Licensed under GPLv2 or any later version
// Refer to the license.txt file included. // Refer to the license.txt file included.
#include "common/logging/log.h"
#include "core/hle/ipc_helpers.h"
#include "core/hle/kernel/hle_ipc.h"
#include "core/hle/service/audio/audrec_u.h" #include "core/hle/service/audio/audrec_u.h"
namespace Service::Audio { namespace Service::Audio {
@ -30,7 +27,6 @@ public:
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~IFinalOutputRecorder() = default;
}; };
AudRecU::AudRecU() : ServiceFramework("audrec:u") { AudRecU::AudRecU() : ServiceFramework("audrec:u") {

View file

@ -18,7 +18,7 @@ class nvmap;
class nvdisp_disp0 final : public nvdevice { class nvdisp_disp0 final : public nvdevice {
public: public:
explicit nvdisp_disp0(std::shared_ptr<nvmap> nvmap_dev); explicit nvdisp_disp0(std::shared_ptr<nvmap> nvmap_dev);
~nvdisp_disp0(); ~nvdisp_disp0() override;
u32 ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) override; u32 ioctl(Ioctl command, const std::vector<u8>& input, std::vector<u8>& output) override;

View file

@ -17,7 +17,7 @@ namespace Service::Nvidia {
class NVDRV final : public ServiceFramework<NVDRV> { class NVDRV final : public ServiceFramework<NVDRV> {
public: public:
NVDRV(std::shared_ptr<Module> nvdrv, const char* name); NVDRV(std::shared_ptr<Module> nvdrv, const char* name);
~NVDRV(); ~NVDRV() override;
private: private:
void Open(Kernel::HLERequestContext& ctx); void Open(Kernel::HLERequestContext& ctx);

View file

@ -11,7 +11,7 @@ namespace Service::Nvidia {
class NVMEMP final : public ServiceFramework<NVMEMP> { class NVMEMP final : public ServiceFramework<NVMEMP> {
public: public:
NVMEMP(); NVMEMP();
~NVMEMP(); ~NVMEMP() override;
private: private:
void Cmd0(Kernel::HLERequestContext& ctx); void Cmd0(Kernel::HLERequestContext& ctx);

View file

@ -90,7 +90,7 @@ private:
Kernel::HLERequestContext& ctx); Kernel::HLERequestContext& ctx);
ServiceFrameworkBase(const char* service_name, u32 max_sessions, InvokerFn* handler_invoker); ServiceFrameworkBase(const char* service_name, u32 max_sessions, InvokerFn* handler_invoker);
~ServiceFrameworkBase(); ~ServiceFrameworkBase() override;
void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n); void RegisterHandlersBase(const FunctionInfoBase* functions, std::size_t n);
void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info); void ReportUnimplementedFunction(Kernel::HLERequestContext& ctx, const FunctionInfoBase* info);

View file

@ -11,7 +11,7 @@ namespace Service::Set {
class SET_CAL final : public ServiceFramework<SET_CAL> { class SET_CAL final : public ServiceFramework<SET_CAL> {
public: public:
explicit SET_CAL(); explicit SET_CAL();
~SET_CAL(); ~SET_CAL() override;
}; };
} // namespace Service::Set } // namespace Service::Set

View file

@ -64,7 +64,6 @@ public:
}; };
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~ISslContext() = default;
private: private:
void SetOption(Kernel::HLERequestContext& ctx) { void SetOption(Kernel::HLERequestContext& ctx) {

View file

@ -498,7 +498,6 @@ public:
}; };
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~IHOSBinderDriver() = default;
private: private:
enum class TransactionId { enum class TransactionId {
@ -692,7 +691,6 @@ public:
}; };
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~ISystemDisplayService() = default;
private: private:
void SetLayerZ(Kernel::HLERequestContext& ctx) { void SetLayerZ(Kernel::HLERequestContext& ctx) {
@ -818,7 +816,6 @@ public:
}; };
RegisterHandlers(functions); RegisterHandlers(functions);
} }
~IManagerDisplayService() = default;
private: private:
void CloseDisplay(Kernel::HLERequestContext& ctx) { void CloseDisplay(Kernel::HLERequestContext& ctx) {
@ -884,7 +881,6 @@ private:
class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> { class IApplicationDisplayService final : public ServiceFramework<IApplicationDisplayService> {
public: public:
explicit IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger); explicit IApplicationDisplayService(std::shared_ptr<NVFlinger::NVFlinger> nv_flinger);
~IApplicationDisplayService() = default;
private: private:
enum class ConvertedScaleMode : u64 { enum class ConvertedScaleMode : u64 {

View file

@ -22,7 +22,7 @@ class AppLoader_NCA;
class AppLoader_XCI final : public AppLoader { class AppLoader_XCI final : public AppLoader {
public: public:
explicit AppLoader_XCI(FileSys::VirtualFile file); explicit AppLoader_XCI(FileSys::VirtualFile file);
~AppLoader_XCI(); ~AppLoader_XCI() override;
/** /**
* Returns the type of the file * Returns the type of the file