mirror of
https://github.com/yuzu-mirror/yuzu.git
synced 2024-09-08 06:29:08 +01:00
fixed_point: Mark default constructor as constexpr
Ensures that a fixed-point value is always initialized This likely also fixes several cases of uninitialized values being operated on, since we have multiple areas in the codebase where the default constructor is being used like: Common::FixedPoint<50, 14> current_sample{}; and is then followed up with an arithmetic operation like += or something else, which operates directly on FixedPoint's internal data member, which would previously be uninitialized.
This commit is contained in:
parent
b6119a55f9
commit
6e1c6297a3
1 changed files with 2 additions and 2 deletions
|
@ -267,7 +267,7 @@ public:
|
||||||
static constexpr base_type one = base_type(1) << fractional_bits;
|
static constexpr base_type one = base_type(1) << fractional_bits;
|
||||||
|
|
||||||
public: // constructors
|
public: // constructors
|
||||||
FixedPoint() = default;
|
constexpr FixedPoint() = default;
|
||||||
|
|
||||||
constexpr FixedPoint(const FixedPoint&) = default;
|
constexpr FixedPoint(const FixedPoint&) = default;
|
||||||
constexpr FixedPoint& operator=(const FixedPoint&) = default;
|
constexpr FixedPoint& operator=(const FixedPoint&) = default;
|
||||||
|
@ -463,7 +463,7 @@ public:
|
||||||
}
|
}
|
||||||
|
|
||||||
public:
|
public:
|
||||||
base_type data_;
|
base_type data_{};
|
||||||
};
|
};
|
||||||
|
|
||||||
// if we have the same fractional portion, but differing integer portions, we trivially upgrade the
|
// if we have the same fractional portion, but differing integer portions, we trivially upgrade the
|
||||||
|
|
Loading…
Reference in a new issue