mirror of
https://github.com/yuzu-mirror/yuzu.git
synced 2024-11-03 07:50:37 +00:00
kernel/transfer_memory: Add accessors to data and sizes
Also amend erroneous use of size_t. We should be using u64 here.
This commit is contained in:
parent
7931a68d4e
commit
140cd5e209
2 changed files with 31 additions and 11 deletions
|
@ -14,8 +14,8 @@ namespace Kernel {
|
||||||
TransferMemory::TransferMemory(KernelCore& kernel) : Object{kernel} {}
|
TransferMemory::TransferMemory(KernelCore& kernel) : Object{kernel} {}
|
||||||
TransferMemory::~TransferMemory() = default;
|
TransferMemory::~TransferMemory() = default;
|
||||||
|
|
||||||
SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_address,
|
SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_address, u64 size,
|
||||||
size_t size, MemoryPermission permissions) {
|
MemoryPermission permissions) {
|
||||||
SharedPtr<TransferMemory> transfer_memory{new TransferMemory(kernel)};
|
SharedPtr<TransferMemory> transfer_memory{new TransferMemory(kernel)};
|
||||||
|
|
||||||
transfer_memory->base_address = base_address;
|
transfer_memory->base_address = base_address;
|
||||||
|
@ -26,7 +26,15 @@ SharedPtr<TransferMemory> TransferMemory::Create(KernelCore& kernel, VAddr base_
|
||||||
return transfer_memory;
|
return transfer_memory;
|
||||||
}
|
}
|
||||||
|
|
||||||
ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermission permissions) {
|
const u8* TransferMemory::GetPointer() const {
|
||||||
|
return backing_block.get()->data();
|
||||||
|
}
|
||||||
|
|
||||||
|
u64 TransferMemory::GetSize() const {
|
||||||
|
return memory_size;
|
||||||
|
}
|
||||||
|
|
||||||
|
ResultCode TransferMemory::MapMemory(VAddr address, u64 size, MemoryPermission permissions) {
|
||||||
if (memory_size != size) {
|
if (memory_size != size) {
|
||||||
return ERR_INVALID_SIZE;
|
return ERR_INVALID_SIZE;
|
||||||
}
|
}
|
||||||
|
@ -39,13 +47,13 @@ ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermissio
|
||||||
return ERR_INVALID_STATE;
|
return ERR_INVALID_STATE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
backing_block = std::make_shared<std::vector<u8>>(size);
|
||||||
|
|
||||||
const auto map_state = owner_permissions == MemoryPermission::None
|
const auto map_state = owner_permissions == MemoryPermission::None
|
||||||
? MemoryState::TransferMemoryIsolated
|
? MemoryState::TransferMemoryIsolated
|
||||||
: MemoryState::TransferMemory;
|
: MemoryState::TransferMemory;
|
||||||
auto& vm_manager = owner_process->VMManager();
|
auto& vm_manager = owner_process->VMManager();
|
||||||
const auto map_result = vm_manager.MapMemoryBlock(
|
const auto map_result = vm_manager.MapMemoryBlock(address, backing_block, 0, size, map_state);
|
||||||
address, std::make_shared<std::vector<u8>>(size), 0, size, map_state);
|
|
||||||
|
|
||||||
if (map_result.Failed()) {
|
if (map_result.Failed()) {
|
||||||
return map_result.Code();
|
return map_result.Code();
|
||||||
}
|
}
|
||||||
|
@ -54,7 +62,7 @@ ResultCode TransferMemory::MapMemory(VAddr address, size_t size, MemoryPermissio
|
||||||
return RESULT_SUCCESS;
|
return RESULT_SUCCESS;
|
||||||
}
|
}
|
||||||
|
|
||||||
ResultCode TransferMemory::UnmapMemory(VAddr address, size_t size) {
|
ResultCode TransferMemory::UnmapMemory(VAddr address, u64 size) {
|
||||||
if (memory_size != size) {
|
if (memory_size != size) {
|
||||||
return ERR_INVALID_SIZE;
|
return ERR_INVALID_SIZE;
|
||||||
}
|
}
|
||||||
|
|
|
@ -4,6 +4,9 @@
|
||||||
|
|
||||||
#pragma once
|
#pragma once
|
||||||
|
|
||||||
|
#include <memory>
|
||||||
|
#include <vector>
|
||||||
|
|
||||||
#include "core/hle/kernel/object.h"
|
#include "core/hle/kernel/object.h"
|
||||||
|
|
||||||
union ResultCode;
|
union ResultCode;
|
||||||
|
@ -25,7 +28,7 @@ class TransferMemory final : public Object {
|
||||||
public:
|
public:
|
||||||
static constexpr HandleType HANDLE_TYPE = HandleType::TransferMemory;
|
static constexpr HandleType HANDLE_TYPE = HandleType::TransferMemory;
|
||||||
|
|
||||||
static SharedPtr<TransferMemory> Create(KernelCore& kernel, VAddr base_address, size_t size,
|
static SharedPtr<TransferMemory> Create(KernelCore& kernel, VAddr base_address, u64 size,
|
||||||
MemoryPermission permissions);
|
MemoryPermission permissions);
|
||||||
|
|
||||||
TransferMemory(const TransferMemory&) = delete;
|
TransferMemory(const TransferMemory&) = delete;
|
||||||
|
@ -46,6 +49,12 @@ public:
|
||||||
return HANDLE_TYPE;
|
return HANDLE_TYPE;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Gets a pointer to the backing block of this instance.
|
||||||
|
const u8* GetPointer() const;
|
||||||
|
|
||||||
|
/// Gets the size of the memory backing this instance in bytes.
|
||||||
|
u64 GetSize() const;
|
||||||
|
|
||||||
/// Attempts to map transfer memory with the given range and memory permissions.
|
/// Attempts to map transfer memory with the given range and memory permissions.
|
||||||
///
|
///
|
||||||
/// @param address The base address to being mapping memory at.
|
/// @param address The base address to being mapping memory at.
|
||||||
|
@ -56,7 +65,7 @@ public:
|
||||||
/// the same values that were given when creating the transfer memory
|
/// the same values that were given when creating the transfer memory
|
||||||
/// instance.
|
/// instance.
|
||||||
///
|
///
|
||||||
ResultCode MapMemory(VAddr address, size_t size, MemoryPermission permissions);
|
ResultCode MapMemory(VAddr address, u64 size, MemoryPermission permissions);
|
||||||
|
|
||||||
/// Unmaps the transfer memory with the given range
|
/// Unmaps the transfer memory with the given range
|
||||||
///
|
///
|
||||||
|
@ -66,17 +75,20 @@ public:
|
||||||
/// @pre The given address and size must be the same as the ones used
|
/// @pre The given address and size must be the same as the ones used
|
||||||
/// to create the transfer memory instance.
|
/// to create the transfer memory instance.
|
||||||
///
|
///
|
||||||
ResultCode UnmapMemory(VAddr address, size_t size);
|
ResultCode UnmapMemory(VAddr address, u64 size);
|
||||||
|
|
||||||
private:
|
private:
|
||||||
explicit TransferMemory(KernelCore& kernel);
|
explicit TransferMemory(KernelCore& kernel);
|
||||||
~TransferMemory() override;
|
~TransferMemory() override;
|
||||||
|
|
||||||
|
/// Memory block backing this instance.
|
||||||
|
std::shared_ptr<std::vector<u8>> backing_block;
|
||||||
|
|
||||||
/// The base address for the memory managed by this instance.
|
/// The base address for the memory managed by this instance.
|
||||||
VAddr base_address = 0;
|
VAddr base_address = 0;
|
||||||
|
|
||||||
/// Size of the memory, in bytes, that this instance manages.
|
/// Size of the memory, in bytes, that this instance manages.
|
||||||
size_t memory_size = 0;
|
u64 memory_size = 0;
|
||||||
|
|
||||||
/// The memory permissions that are applied to this instance.
|
/// The memory permissions that are applied to this instance.
|
||||||
MemoryPermission owner_permissions{};
|
MemoryPermission owner_permissions{};
|
||||||
|
|
Loading…
Reference in a new issue