Mirrors/xcaddy
1
0
Fork 0
mirror of https://github.com/caddyserver/xcaddy.git synced 2024-11-05 08:50:07 +00:00
Code Issues Projects Releases Packages Wiki Activity
xcaddy/cmd/main_unix_test.go

109 lines
3 KiB
Go
Raw Normal View History

Handle replacements robustly (#69) * Parse JSON output of 'go list' It's more robust in this way * Handle all possible replacements properly for runDev() 1. Handle all possible replacements properly for runDev() Replacement targets are not always paths. Reference: https://pkg.go.dev/cmd/go/internal/list#pkg-variables 2. Parse replacement info from 'go list -m -json all' It's more robust in this way * Test the 'go list -m -json all' parsing logic * Call 'go list' command only once `go list -m -json all` contains all informations we need so we don't need extra `go list -m -json` call. * main_windows_test.go: Make tests for Windows * Support Go 1.16 * Use struct instead of map[string]interface{} * extract and unexport the `module` struct Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>
2021-09-01 19:30:45 +01:00
//go:build !windows
// +build !windows
package xcaddycmd
import (
"reflect"
"testing"
"github.com/caddyserver/xcaddy"
)
func TestParseGoListJson(t *testing.T) {
currentModule, moduleDir, replacements, err := parseGoListJson([]byte(`
{
"Path": "replacetest1",
"Version": "v1.2.3",
"Replace": {
"Path": "golang.org/x/example",
"Version": "v0.0.0-20210811190340-787a929d5a0d",
"Time": "2021-08-11T19:03:40Z",
"GoMod": "/home/simnalamburt/.go/pkg/mod/cache/download/golang.org/x/example/@v/v0.0.0-20210811190340-787a929d5a0d.mod",
"GoVersion": "1.15"
},
"GoMod": "/home/simnalamburt/.go/pkg/mod/cache/download/golang.org/x/example/@v/v0.0.0-20210811190340-787a929d5a0d.mod",
"GoVersion": "1.15"
}
{
"Path": "replacetest2",
"Version": "v0.0.1",
"Replace": {
"Path": "golang.org/x/example",
"Version": "v0.0.0-20210407023211-09c3a5e06b5d",
"Time": "2021-04-07T02:32:11Z",
"GoMod": "/home/simnalamburt/.go/pkg/mod/cache/download/golang.org/x/example/@v/v0.0.0-20210407023211-09c3a5e06b5d.mod",
"GoVersion": "1.15"
},
"GoMod": "/home/simnalamburt/.go/pkg/mod/cache/download/golang.org/x/example/@v/v0.0.0-20210407023211-09c3a5e06b5d.mod",
"GoVersion": "1.15"
}
{
"Path": "replacetest3",
"Version": "v1.2.3",
"Replace": {
"Path": "./fork1",
"Dir": "/home/work/module/fork1",
"GoMod": "/home/work/module/fork1/go.mod",
"GoVersion": "1.17"
},
"Dir": "/home/work/module/fork1",
"GoMod": "/home/work/module/fork1/go.mod",
"GoVersion": "1.17"
}
{
"Path": "github.com/simnalamburt/module",
"Main": true,
"Dir": "/home/work/module",
"GoMod": "/home/work/module/go.mod",
"GoVersion": "1.17"
}
{
"Path": "replacetest4",
"Version": "v0.0.1",
"Replace": {
"Path": "/srv/fork2",
"Dir": "/home/work/module/fork2",
"GoMod": "/home/work/module/fork2/go.mod",
"GoVersion": "1.17"
},
"Dir": "/home/work/module/fork2",
"GoMod": "/home/work/module/fork2/go.mod",
"GoVersion": "1.17"
}
{
"Path": "replacetest5",
"Version": "v1.2.3",
"Replace": {
"Path": "./fork3",
"Dir": "/home/work/module/fork3",
"GoMod": "/home/work/module/fork3/go.mod",
"GoVersion": "1.17"
},
"Dir": "/home/work/module/fork3",
"GoMod": "/home/work/module/fork3/go.mod",
"GoVersion": "1.17"
}
`))
if err != nil {
t.Errorf("Error occured during JSON parsing")
}
if currentModule != "github.com/simnalamburt/module" {
t.Errorf("Unexpected module name")
}
if moduleDir != "/home/work/module" {
t.Errorf("Unexpected module path")
}
expected := []xcaddy.Replace{
Don't include version in replacement source Follow-up to #69 I had a situation where caddy/v2 v2.4.6 was in my go.mod and a replace on it to use local caddy repo. When I ran `xcaddy run` to test a caddy module, it failed to run because the replace included the version v2.4.6, even though somehow the buildenv go.mod had v2.6.1 (the latest), and the replace directive specified @v2.4.6 only, so the replacement didn't happen. I don't think versions in the replacement source/origin are really that useful for xcaddy. If experience proves this wrong, we can figure out a better solution.
2022-09-28 17:25:38 +01:00
xcaddy.NewReplace("replacetest1", "golang.org/x/example@v0.0.0-20210811190340-787a929d5a0d"),
xcaddy.NewReplace("replacetest2", "golang.org/x/example@v0.0.0-20210407023211-09c3a5e06b5d"),
xcaddy.NewReplace("replacetest3", "/home/work/module/fork1"),
Handle replacements robustly (#69) * Parse JSON output of 'go list' It's more robust in this way * Handle all possible replacements properly for runDev() 1. Handle all possible replacements properly for runDev() Replacement targets are not always paths. Reference: https://pkg.go.dev/cmd/go/internal/list#pkg-variables 2. Parse replacement info from 'go list -m -json all' It's more robust in this way * Test the 'go list -m -json all' parsing logic * Call 'go list' command only once `go list -m -json all` contains all informations we need so we don't need extra `go list -m -json` call. * main_windows_test.go: Make tests for Windows * Support Go 1.16 * Use struct instead of map[string]interface{} * extract and unexport the `module` struct Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>
2021-09-01 19:30:45 +01:00
xcaddy.NewReplace("github.com/simnalamburt/module", "/home/work/module"),
Don't include version in replacement source Follow-up to #69 I had a situation where caddy/v2 v2.4.6 was in my go.mod and a replace on it to use local caddy repo. When I ran `xcaddy run` to test a caddy module, it failed to run because the replace included the version v2.4.6, even though somehow the buildenv go.mod had v2.6.1 (the latest), and the replace directive specified @v2.4.6 only, so the replacement didn't happen. I don't think versions in the replacement source/origin are really that useful for xcaddy. If experience proves this wrong, we can figure out a better solution.
2022-09-28 17:25:38 +01:00
xcaddy.NewReplace("replacetest4", "/srv/fork2"),
xcaddy.NewReplace("replacetest5", "/home/work/module/fork3"),
Handle replacements robustly (#69) * Parse JSON output of 'go list' It's more robust in this way * Handle all possible replacements properly for runDev() 1. Handle all possible replacements properly for runDev() Replacement targets are not always paths. Reference: https://pkg.go.dev/cmd/go/internal/list#pkg-variables 2. Parse replacement info from 'go list -m -json all' It's more robust in this way * Test the 'go list -m -json all' parsing logic * Call 'go list' command only once `go list -m -json all` contains all informations we need so we don't need extra `go list -m -json` call. * main_windows_test.go: Make tests for Windows * Support Go 1.16 * Use struct instead of map[string]interface{} * extract and unexport the `module` struct Co-authored-by: Mohammed Al Sahaf <msaa1990@gmail.com>
2021-09-01 19:30:45 +01:00
}
if !reflect.DeepEqual(replacements, expected) {
t.Errorf("Expected replacements '%v' but got '%v'", expected, replacements)
}
}
Reference in a new issue Copy permalink