Refactoring: rename ArchiveViewer

This commit is contained in:
Ming Ming 2021-08-01 01:02:41 +08:00
parent ed19b1bd82
commit f95251a527
3 changed files with 23 additions and 22 deletions

View file

@ -24,38 +24,38 @@ import 'package:nc_photos/widget/selection_app_bar.dart';
import 'package:nc_photos/widget/viewer.dart';
import 'package:nc_photos/widget/zoom_menu_button.dart';
class ArchiveViewerArguments {
ArchiveViewerArguments(this.account);
class ArchiveBrowserArguments {
ArchiveBrowserArguments(this.account);
final Account account;
}
class ArchiveViewer extends StatefulWidget {
static const routeName = "/archive-viewer";
class ArchiveBrowser extends StatefulWidget {
static const routeName = "/archive-browser";
static Route buildRoute(ArchiveViewerArguments args) => MaterialPageRoute(
builder: (context) => ArchiveViewer.fromArgs(args),
static Route buildRoute(ArchiveBrowserArguments args) => MaterialPageRoute(
builder: (context) => ArchiveBrowser.fromArgs(args),
);
ArchiveViewer({
ArchiveBrowser({
Key? key,
required this.account,
}) : super(key: key);
ArchiveViewer.fromArgs(ArchiveViewerArguments args, {Key? key})
ArchiveBrowser.fromArgs(ArchiveBrowserArguments args, {Key? key})
: this(
key: key,
account: args.account,
);
@override
createState() => _ArchiveViewerState();
createState() => _ArchiveBrowserState();
final Account account;
}
class _ArchiveViewerState extends State<ArchiveViewer>
with SelectableItemStreamListMixin<ArchiveViewer> {
class _ArchiveBrowserState extends State<ArchiveBrowser>
with SelectableItemStreamListMixin<ArchiveBrowser> {
@override
initState() {
super.initState();
@ -301,7 +301,7 @@ class _ArchiveViewerState extends State<ArchiveViewer>
var _thumbZoomLevel = 0;
static final _log = Logger("widget.archive_viewer._ArchiveViewerState");
static final _log = Logger("widget.archive_browser._ArchiveBrowserState");
}
abstract class _ListItem implements SelectableItem {

View file

@ -22,7 +22,7 @@ import 'package:nc_photos/widget/album_grid_item.dart';
import 'package:nc_photos/widget/album_importer.dart';
import 'package:nc_photos/widget/album_search_delegate.dart';
import 'package:nc_photos/widget/album_viewer.dart';
import 'package:nc_photos/widget/archive_viewer.dart';
import 'package:nc_photos/widget/archive_browser.dart';
import 'package:nc_photos/widget/builder/album_grid_item_builder.dart';
import 'package:nc_photos/widget/dynamic_album_viewer.dart';
import 'package:nc_photos/widget/home_app_bar.dart';
@ -217,8 +217,8 @@ class _HomeAlbumsState extends State<HomeAlbums>
),
title: L10n.of(context).albumArchiveLabel,
onTap: () {
Navigator.of(context).pushNamed(ArchiveViewer.routeName,
arguments: ArchiveViewerArguments(widget.account));
Navigator.of(context).pushNamed(ArchiveBrowser.routeName,
arguments: ArchiveBrowserArguments(widget.account));
},
);
}

View file

@ -11,7 +11,7 @@ import 'package:nc_photos/theme.dart';
import 'package:nc_photos/widget/album_dir_picker.dart';
import 'package:nc_photos/widget/album_importer.dart';
import 'package:nc_photos/widget/album_viewer.dart';
import 'package:nc_photos/widget/archive_viewer.dart';
import 'package:nc_photos/widget/archive_browser.dart';
import 'package:nc_photos/widget/connect.dart';
import 'package:nc_photos/widget/dynamic_album_viewer.dart';
import 'package:nc_photos/widget/home.dart';
@ -99,7 +99,7 @@ class _MyAppState extends State<MyApp> implements SnackBarHandler {
route ??= _handleRootPickerRoute(settings);
route ??= _handleAlbumViewerRoute(settings);
route ??= _handleSettingsRoute(settings);
route ??= _handleArchiveViewerRoute(settings);
route ??= _handleArchiveBrowserRoute(settings);
route ??= _handleDynamicAlbumViewerRoute(settings);
route ??= _handleAlbumDirPickerRoute(settings);
route ??= _handleAlbumImporterRoute(settings);
@ -198,15 +198,16 @@ class _MyAppState extends State<MyApp> implements SnackBarHandler {
return null;
}
Route<dynamic>? _handleArchiveViewerRoute(RouteSettings settings) {
Route<dynamic>? _handleArchiveBrowserRoute(RouteSettings settings) {
try {
if (settings.name == ArchiveViewer.routeName &&
if (settings.name == ArchiveBrowser.routeName &&
settings.arguments != null) {
final args = settings.arguments as ArchiveViewerArguments;
return ArchiveViewer.buildRoute(args);
final args = settings.arguments as ArchiveBrowserArguments;
return ArchiveBrowser.buildRoute(args);
}
} catch (e) {
_log.severe("[_handleArchiveViewerRoute] Failed while handling route", e);
_log.severe(
"[_handleArchiveBrowserRoute] Failed while handling route", e);
}
return null;
}