Mirrors/nc-photos
1
0
Fork 0
mirror of https://gitlab.com/nkming2/nc-photos.git synced 2025-03-24 16:04:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix non-unique key used to detect visibility

Browse source
This commit is contained in:
Ming Ming 2022-07-24 03:29:00 +08:00
parent e5fa14943c
commit dccb57f32e
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/lib/widget/selectable_item_stream_list_mixin.dart
View file

@ -12,6 +12,7 @@ import 'package:nc_photos/session_storage.dart';
import 'package:nc_photos/snack_bar_manager.dart'; import 'package:nc_photos/snack_bar_manager.dart';
import 'package:nc_photos/widget/measurable_item_list.dart'; import 'package:nc_photos/widget/measurable_item_list.dart';
import 'package:nc_photos/widget/selectable.dart'; import 'package:nc_photos/widget/selectable.dart';
import 'package:uuid/uuid.dart';
import 'package:visibility_detector/visibility_detector.dart'; import 'package:visibility_detector/visibility_detector.dart';
abstract class SelectableItem { abstract class SelectableItem {
@ -164,7 +165,7 @@ mixin SelectableItemStreamListMixin<T extends StatefulWidget> on State<T> {
} }
if (isEnableVisibilityCallback) { if (isEnableVisibilityCallback) {
content = VisibilityDetector( content = VisibilityDetector(
key: Key("$index"), key: Key("$_itemKeyPrefix.$index"),
child: content, child: content,
onVisibilityChanged: (info) => onVisibilityChanged(info, index, item), onVisibilityChanged: (info) => onVisibilityChanged(info, index, item),
); );
@ -271,6 +272,8 @@ mixin SelectableItemStreamListMixin<T extends StatefulWidget> on State<T> {
final _selectedItems = <SelectableItem>{}; final _selectedItems = <SelectableItem>{};
final _listKey = GlobalKey(); final _listKey = GlobalKey();
late final _itemKeyPrefix =
"widget.selectable_item_stream_list_mixin.SelectableItemStreamListMixin.${const Uuid().v4()}";
/// used to gain focus on web for keyboard support /// used to gain focus on web for keyboard support
final _keyboardFocus = FocusNode(); final _keyboardFocus = FocusNode();