Mirrors/nc-photos
1
0
Fork 0
mirror of https://gitlab.com/nkming2/nc-photos.git synced 2025-03-24 16:04:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Avoid potential copying of item list

Browse source
This commit is contained in:
Ming Ming 2021-07-08 02:51:34 +08:00
parent 4fb6c022d2
commit c04c9ae7b0
5 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/widget/album_viewer.dart
View file

@ -278,7 +278,8 @@ class _AlbumViewerState extends State<AlbumViewer>
"[_transformItems] Unsupported file format: ${f.contentType}"); "[_transformItems] Unsupported file format: ${f.contentType}");
} }
} }
}(); }()
.toList();
} }
bool _shouldPropagateResyncedAlbum(Album album) { bool _shouldPropagateResyncedAlbum(Album album) {

3
lib/widget/archive_viewer.dart
View file

@ -280,7 +280,8 @@ class _ArchiveViewerState extends State<ArchiveViewer>
"[_transformItems] Unsupported file format: ${f.contentType}"); "[_transformItems] Unsupported file format: ${f.contentType}");
} }
} }
}(); }()
.toList();
} }
void _reqQuery() { void _reqQuery() {

3
lib/widget/dynamic_album_viewer.dart
View file

@ -402,7 +402,8 @@ class _DynamicAlbumViewerState extends State<DynamicAlbumViewer>
"[_onBackingFilesUpdated] Unsupported file format: ${f.contentType}"); "[_onBackingFilesUpdated] Unsupported file format: ${f.contentType}");
} }
} }
}(); }()
.toList();
} }
Album _album; Album _album;

3
lib/widget/home_photos.dart
View file

@ -483,7 +483,8 @@ class _HomePhotosState extends State<HomePhotos>
"[_transformItems] Unsupported file format: ${f.contentType}"); "[_transformItems] Unsupported file format: ${f.contentType}");
} }
} }
}(); }()
.toList();
} }
void _reqQuery() { void _reqQuery() {

8
lib/widget/selectable_item_stream_list_mixin.dart
View file

@ -78,13 +78,11 @@ mixin SelectableItemStreamListMixin<T extends StatefulWidget> on State<T> {
List<SelectableItem> get itemStreamListItems => UnmodifiableListView(_items); List<SelectableItem> get itemStreamListItems => UnmodifiableListView(_items);
@protected @protected
set itemStreamListItems(Iterable<SelectableItem> newItems) { set itemStreamListItems(List<SelectableItem> newItems) {
final lastSelectedItem = final lastSelectedItem =
_lastSelectPosition != null ? _items[_lastSelectPosition] : null; _lastSelectPosition != null ? _items[_lastSelectPosition] : null;
_items.clear(); _items = newItems;
_items.addAll(newItems);
_transformSelectedItems(); _transformSelectedItems();
// Keep _lastSelectPosition if no changes, drop otherwise // Keep _lastSelectPosition if no changes, drop otherwise
@ -216,7 +214,7 @@ mixin SelectableItemStreamListMixin<T extends StatefulWidget> on State<T> {
int _lastSelectPosition; int _lastSelectPosition;
bool _isRangeSelectionMode = false; bool _isRangeSelectionMode = false;
final _items = <SelectableItem>[]; var _items = <SelectableItem>[];
final _selectedItems = <SelectableItem>{}; final _selectedItems = <SelectableItem>{};
final _listKey = GlobalKey(); final _listKey = GlobalKey();