Mirrors/nc-photos
1
0
Fork 0
mirror of https://gitlab.com/nkming2/nc-photos.git synced 2025-03-25 08:24:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Make Disposable less confusing

Browse source
This commit is contained in:
Ming Ming 2021-09-15 04:37:59 +08:00
parent 1f4b43459c
commit 88ba985a1a
2 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/widget/disposable.dart
View file

@ -9,18 +9,24 @@ mixin DisposableManagerMixin<T extends StatefulWidget> on State<T> {
@override @override
initState() { initState() {
super.initState(); super.initState();
for (final d in disposables) { for (final d in _disposables) {
d.init(this); d.init(this);
} }
} }
@override @override
dispose() { dispose() {
for (final d in disposables) { for (final d in _disposables) {
d.dispose(this); d.dispose(this);
} }
super.dispose(); super.dispose();
} }
List<Disposable> get disposables; /// Return a list of [Disposable] to be managed
@mustCallSuper
List<Disposable> initDisposables() {
return [];
}
late final _disposables = initDisposables();
} }

22
lib/widget/viewer.dart
View file

@ -86,6 +86,19 @@ class Viewer extends StatefulWidget {
} }
class _ViewerState extends State<Viewer> with DisposableManagerMixin<Viewer> { class _ViewerState extends State<Viewer> with DisposableManagerMixin<Viewer> {
@override
initDisposables() {
return [
...super.initDisposables(),
if (platform_k.isMobile) _ViewerBrightnessController(),
_ViewerSystemUiResetter(),
if (platform_k.isMobile && Pref.inst().isViewerForceRotationOr(false))
_ViewerOrientationController(
onChanged: _onOrientationChanged,
),
];
}
@override @override
build(BuildContext context) { build(BuildContext context) {
return AppTheme( return AppTheme(
@ -644,15 +657,6 @@ class _ViewerState extends State<Viewer> with DisposableManagerMixin<Viewer> {
bool _canOpenDetailPane() => !_isZoomed; bool _canOpenDetailPane() => !_isZoomed;
bool _canZoom() => !_isDetailPaneActive; bool _canZoom() => !_isDetailPaneActive;
late final disposables = [
if (platform_k.isMobile) _ViewerBrightnessController(),
_ViewerSystemUiResetter(),
if (platform_k.isMobile && Pref.inst().isViewerForceRotationOr(false))
_ViewerOrientationController(
onChanged: _onOrientationChanged,
),
];
var _isShowAppBar = true; var _isShowAppBar = true;
var _isShowDetailPane = false; var _isShowDetailPane = false;