gotosocial/internal/federation/dereferencing
ewwwin 424f62dd70
[bugfix] Store and expose status content type (#3870)
* Add ContentType to internal models

* Add ContentType to API models StatusSource and StatusEdit

* Add helpers to convert between API/internal StatusContentType

* Write status content type on create/edit

* Add migration

* Update API docs

go run github.com/go-swagger/go-swagger/cmd/swagger generate spec --scan-models --exclude-deps --output docs/api/swagger.yaml

* ensure ContentType is updated anywhere Text is

* Update docs, take care of TODOs

* Set ContentType in more places where Text is set

* We don't actually use ContentType on the API status model

* Update StatusSource test

* Remove unused helper function I copied

* Revert change to StatusContentType swagger annotation

I'm going to include this in a follow-on PR instead.

* Add test for updating content type in edits

* Return a value from processContentType instead of modifying the existing status

Fixes an issue that was caught by the test I just added - the recorded edit would be marked with the *new* content type instead of the old one, which is obviously bad

* Add test for handling of statuses with no stored content type

* repurpose an existing test status instead of adding a new one to avoid breaking other tests

* Add test to ensure newly created statuses always have content type saved

* Do include content type on status API model actually

This is mostly important when deleting and redrafting.

The comment on `apimodel.Status.Text` implies that it's not sent except in response to status deletion, but actually this doesn't seem to be the case; it also appears to be present in responses to creations and normal fetches and stuff. So I'm treating `ContentType` the same here.

* Update new tests to check content type on API statuses

* Check content type of API statuses in all tests where text is checked

* update other api tests with status content type field

* Add test ensuring text and content type are returned when deleting a status

* Convert processContentType to free function and remove unused parameter

* check for the correct value in the deletion test

* Be explicit about this test status having an empty content type

* Use omitempty consistently on API models

* clean up the final diff a bit

* one more swagger regen for the road

* Handle nil statuses in processContentType

* Don't pass processContentType the entire edit form, it doesn't need it

* Move processContentType to common.go and use for creation as well

* Remove unused parameters to ContentTypeToAPIContentType
2025-03-06 16:31:52 +00:00
..
account.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
account_test.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
announce.go [feature] add support for receiving federated status edits (#3597) 2024-12-05 13:35:07 +00:00
authenticate.go [security] harden account update logic (#3198) 2024-08-13 15:37:09 +00:00
collection.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
dereferencer.go [feature] add support for clients editing statuses and fetching status revision history (#3628) 2024-12-23 17:54:44 +00:00
dereferencer_test.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
emoji.go [bugfix] fix refreshed additional media info being ignored (#3867) 2025-03-03 16:14:27 +00:00
emoji_test.go [feature] support processing of (many) more media types (#3090) 2024-07-12 09:39:47 +00:00
finger.go [bugfix] relax missing preferred_username, instead using webfingered username (#3189) 2024-08-13 09:01:50 +00:00
handshake.go [chore/security] refactor AuthenticateFederatedRequest() to handle account deref + suspension checks (#2371) 2023-11-21 11:35:30 +01:00
instance.go [bug] respect X-Robots-Tag and robots.txt on api/v1/instance and nodeinfo (#3756) 2025-02-11 13:16:14 +01:00
instance_test.go [feature] Implement backfilling statuses thru scheduled_at (#3685) 2025-02-12 09:49:33 -08:00
media.go [bugfix] fix refreshed additional media info being ignored (#3867) 2025-03-03 16:14:27 +00:00
status.go [bugfix] Store and expose status content type (#3870) 2025-03-06 16:31:52 +00:00
status_permitted.go [feature] Forward-compatibility with Approval objects (#3807) 2025-02-19 18:09:54 +01:00
status_test.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
thread.go [chore] github.com/superseriousbusiness/activity -> codeberg.org/superseriousbusiness/activity (#3853) 2025-03-02 12:48:00 +01:00
util.go [feature] add support for receiving federated status edits (#3597) 2024-12-05 13:35:07 +00:00