Mirrors/cobalt
1
0
Fork 0
mirror of https://github.com/wukko/cobalt.git synced 2024-11-15 12:50:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

web/download: show an explanation when user activation expires

Browse source
This commit is contained in:
wukko 2024-09-09 12:53:22 +06:00
parent dcbda243a2
commit fbe8ccfc2a
No known key found for this signature in database
GPG key ID: 3E30B3F26C7B4AA2
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
web/i18n/en/dialog.json
View file

@ -9,6 +9,7 @@
"saving.title": "choose how to save", "saving.title": "choose how to save",
"saving.blocked": "cobalt tried opening the file in a new tab, but your browser blocked it. you can allow pop-ups for cobalt to prevent this from happening next time.", "saving.blocked": "cobalt tried opening the file in a new tab, but your browser blocked it. you can allow pop-ups for cobalt to prevent this from happening next time.",
"saving.timeout": "cobalt tried saving the file automatically, but your browser stopped it. you have to select a preferred method manually.",
"safety.title": "important safety notice", "safety.title": "important safety notice",

15
web/src/lib/download.ts
View file

@ -65,18 +65,25 @@ export const downloadFile = ({ url, file }: { url?: string, file?: File }) => {
const pref = get(settings).save.savingMethod; const pref = get(settings).save.savingMethod;
if (pref === "ask") {
return openSavingDialog({ url, file });
}
/* /*
user actions (such as invoke share, open new tab) have expiration. user actions (such as invoke share, open new tab) have expiration.
in webkit, for example, that timeout is 5 seconds. in webkit, for example, that timeout is 5 seconds.
https://github.com/WebKit/WebKit/blob/b838f8bb3573bd5906bc5f02fcc8cb274b3c9b8a/Source/WebCore/page/LocalDOMWindow.cpp#L167 https://github.com/WebKit/WebKit/blob/b838f8bb/Source/WebCore/page/LocalDOMWindow.cpp#L167
navigator.userActivation.isActive makes sure that we're still able to navigator.userActivation.isActive makes sure that we're still able to
invoke an action without the user agent interrupting it. invoke an action without the user agent interrupting it.
if not, we show a saving dialog for user to re-invoke that action. if not, we show a saving dialog for user to re-invoke that action.
*/ */
if (!navigator.userActivation.isActive) {
if (pref === "ask" || !navigator.userActivation.isActive) { return openSavingDialog({
return openSavingDialog({ url, file }); url,
file,
body: get(t)("dialog.saving.timeout"),
});
} }
try { try {