Mirrors/caddy
1
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2025-02-24 16:59:00 +01:00
Code Issues Projects Releases Packages Wiki Activity

fastcgi: Make sure splitPos handles empty SplitPath correctly (#3491)

Browse source 
In commit f2ce81c, support for multiple path splitters was added. The
type of SplitPath changed from string to []string, and splitPos was
changed to loop through all values in SplitPath.

Before that commit, if SplitPath was empty, strings.Index returned 0 and
PATH_INFO was set correctly in buildEnv.

Currently, however, splitPos returns -1 for empty values of SplitPath,
behaving as if a split position could not be found at all. PATH_INFO is
then never set in buildEnv and remains empty.

Restore the old behaviour by explicitly checking whether SplitPath is
empty and returning 0 in splitPos.

Closes #3490
This commit is contained in:
Wynn Wolf Arbor 2020-06-12 18:07:59 +02:00 committed by GitHub
parent d55c3b31eb
commit fa4cdde7d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/caddyhttp/reverseproxy/fastcgi/fastcgi.go
View file

@ -303,6 +303,10 @@ func (t Transport) splitPos(path string) int {
// if httpserver.CaseSensitivePath { // if httpserver.CaseSensitivePath {
// return strings.Index(path, r.SplitPath) // return strings.Index(path, r.SplitPath)
// } // }
if len(t.SplitPath) == 0 {
return 0
}
lowerPath := strings.ToLower(path) lowerPath := strings.ToLower(path)
for _, split := range t.SplitPath { for _, split := range t.SplitPath {
if idx := strings.Index(lowerPath, strings.ToLower(split)); idx > -1 { if idx := strings.Index(lowerPath, strings.ToLower(split)); idx > -1 {