From a6a350ddc3bf708276e27045e326f108f733f0b1 Mon Sep 17 00:00:00 2001 From: ReinUsesLisp Date: Fri, 21 Feb 2020 03:25:29 -0300 Subject: [PATCH] gl_texture_cache: Remove blending disable on blits Blending doesn't affect blits. Rasterizer discard does, update the commentaries. --- src/video_core/renderer_opengl/gl_texture_cache.cpp | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/video_core/renderer_opengl/gl_texture_cache.cpp b/src/video_core/renderer_opengl/gl_texture_cache.cpp index 4b86018d5..2d3838a7a 100644 --- a/src/video_core/renderer_opengl/gl_texture_cache.cpp +++ b/src/video_core/renderer_opengl/gl_texture_cache.cpp @@ -518,9 +518,7 @@ void TextureCacheOpenGL::ImageBlit(View& src_view, View& dst_view, UNIMPLEMENTED_IF(src_params.target == SurfaceTarget::Texture3D); UNIMPLEMENTED_IF(dst_params.target == SurfaceTarget::Texture3D); - // TODO: Signal state tracker about these changes state_tracker.NotifyScissor0(); - state_tracker.NotifyBlend0(); state_tracker.NotifyFramebuffer(); state_tracker.NotifyRasterizeEnable(); state_tracker.NotifyFramebufferSRGB(); @@ -530,11 +528,8 @@ void TextureCacheOpenGL::ImageBlit(View& src_view, View& dst_view, } else { glDisable(GL_FRAMEBUFFER_SRGB); } - // TODO(Rodrigo): Find out if rasterizer discard affects blits - // TODO(Rodrigo): Find out if blending affects blits glDisable(GL_RASTERIZER_DISCARD); glDisablei(GL_SCISSOR_TEST, 0); - glDisablei(GL_BLEND, 0); glBindFramebuffer(GL_READ_FRAMEBUFFER, src_framebuffer.handle); glBindFramebuffer(GL_DRAW_FRAMEBUFFER, dst_framebuffer.handle);