From 634b78a4c6db225e71799107da913799d84450cd Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 19 May 2019 02:50:47 -0400 Subject: [PATCH] gl_shader_disk_cache: Default ShaderDiskCacheOpenGL's destructor in the cpp file Given the disk shader cache contains non-trivial types, we should default it in the cpp file in order to prevent inlining of the complex destruction logic. --- src/video_core/renderer_opengl/gl_shader_disk_cache.cpp | 2 ++ src/video_core/renderer_opengl/gl_shader_disk_cache.h | 1 + 2 files changed, 3 insertions(+) diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp index 4cfb88557..c446945ee 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.cpp @@ -107,6 +107,8 @@ bool ShaderDiskCacheRaw::Save(FileUtil::IOFile& file) const { ShaderDiskCacheOpenGL::ShaderDiskCacheOpenGL(Core::System& system) : system{system}, precompiled_cache_virtual_file_offset{0} {} +ShaderDiskCacheOpenGL::~ShaderDiskCacheOpenGL() = default; + std::optional, std::vector>> ShaderDiskCacheOpenGL::LoadTransferable() { // Skip games without title id diff --git a/src/video_core/renderer_opengl/gl_shader_disk_cache.h b/src/video_core/renderer_opengl/gl_shader_disk_cache.h index 7a7183f21..bafd3b3f2 100644 --- a/src/video_core/renderer_opengl/gl_shader_disk_cache.h +++ b/src/video_core/renderer_opengl/gl_shader_disk_cache.h @@ -162,6 +162,7 @@ struct ShaderDiskCacheDump { class ShaderDiskCacheOpenGL { public: explicit ShaderDiskCacheOpenGL(Core::System& system); + ~ShaderDiskCacheOpenGL(); /// Loads transferable cache. If file has a old version or on failure, it deletes the file. std::optional, std::vector>>