From 93ac8d0feadc129fdfdbaccd0c4e444b34ce2f15 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 9 Oct 2018 13:34:38 -0400 Subject: [PATCH] ips_layer: std::move data within PatchIPS() and Apply() We don't need to make a copy of the read data, so we can std::move it into the make_shared call here. --- src/core/file_sys/ips_layer.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/core/file_sys/ips_layer.cpp b/src/core/file_sys/ips_layer.cpp index 0cadbc375..b7a3df1b0 100644 --- a/src/core/file_sys/ips_layer.cpp +++ b/src/core/file_sys/ips_layer.cpp @@ -90,7 +90,9 @@ VirtualFile PatchIPS(const VirtualFile& in, const VirtualFile& ips) { if (temp != std::vector{'E', 'E', 'O', 'F'} && temp != std::vector{'E', 'O', 'F'}) return nullptr; - return std::make_shared(in_data, in->GetName(), in->GetContainingDirectory()); + + return std::make_shared(std::move(in_data), in->GetName(), + in->GetContainingDirectory()); } IPSwitchCompiler::IPSwitchCompiler(VirtualFile patch_text_) : patch_text(std::move(patch_text_)) { @@ -291,7 +293,8 @@ VirtualFile IPSwitchCompiler::Apply(const VirtualFile& in) const { } } - return std::make_shared(in_data, in->GetName(), in->GetContainingDirectory()); + return std::make_shared(std::move(in_data), in->GetName(), + in->GetContainingDirectory()); } } // namespace FileSys