From 17b4355391f872f238a971fbece12ebd1b7773cb Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 5 Dec 2018 15:59:48 -0500 Subject: [PATCH] yuzu/wait_tree: Pass QString by value and std::move in the initializer list for WaitTreeText Just a trivial modernization that potentially avoids copying strings in certain scenarios. --- src/yuzu/debugger/wait_tree.cpp | 2 +- src/yuzu/debugger/wait_tree.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/yuzu/debugger/wait_tree.cpp b/src/yuzu/debugger/wait_tree.cpp index f9c18ede4..6b3a757e0 100644 --- a/src/yuzu/debugger/wait_tree.cpp +++ b/src/yuzu/debugger/wait_tree.cpp @@ -75,7 +75,7 @@ std::vector> WaitTreeItem::MakeThreadItemList() return item_list; } -WaitTreeText::WaitTreeText(const QString& t) : text(t) {} +WaitTreeText::WaitTreeText(QString t) : text(std::move(t)) {} WaitTreeText::~WaitTreeText() = default; QString WaitTreeText::GetText() const { diff --git a/src/yuzu/debugger/wait_tree.h b/src/yuzu/debugger/wait_tree.h index 492fb6ac9..e639ef412 100644 --- a/src/yuzu/debugger/wait_tree.h +++ b/src/yuzu/debugger/wait_tree.h @@ -52,7 +52,7 @@ private: class WaitTreeText : public WaitTreeItem { Q_OBJECT public: - explicit WaitTreeText(const QString& text); + explicit WaitTreeText(QString text); ~WaitTreeText() override; QString GetText() const override;