From 73a2d71f449020dbf4e0cc165de8b1b157bc927c Mon Sep 17 00:00:00 2001 From: Lioncash Date: Sun, 9 Sep 2018 19:35:05 -0400 Subject: [PATCH] game_list: Make CompatibilityList parameter of NavigateToGamedbEntryRequested() a const reference The compatibility list isn't modified within any of the slots connected to this signal, so we can make it const to enforce immutability. --- src/yuzu/game_list.h | 3 ++- src/yuzu/main.cpp | 2 +- src/yuzu/main.h | 3 ++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/yuzu/game_list.h b/src/yuzu/game_list.h index e01b44c20..2713e7b54 100644 --- a/src/yuzu/game_list.h +++ b/src/yuzu/game_list.h @@ -89,7 +89,8 @@ signals: void GameChosen(QString game_path); void ShouldCancelWorker(); void OpenFolderRequested(u64 program_id, GameListOpenTarget target); - void NavigateToGamedbEntryRequested(u64 program_id, CompatibilityList& compatibility_list); + void NavigateToGamedbEntryRequested(u64 program_id, + const CompatibilityList& compatibility_list); private slots: void onTextChanged(const QString& newText); diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cpp index 366169eef..e36914f14 100644 --- a/src/yuzu/main.cpp +++ b/src/yuzu/main.cpp @@ -727,7 +727,7 @@ void GMainWindow::OnGameListOpenFolder(u64 program_id, GameListOpenTarget target } void GMainWindow::OnGameListNavigateToGamedbEntry(u64 program_id, - CompatibilityList& compatibility_list) { + const CompatibilityList& compatibility_list) { const auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id); QString directory; diff --git a/src/yuzu/main.h b/src/yuzu/main.h index 64516a332..552e3e61c 100644 --- a/src/yuzu/main.h +++ b/src/yuzu/main.h @@ -138,7 +138,8 @@ private slots: /// Called whenever a user selects a game in the game list widget. void OnGameListLoadFile(QString game_path); void OnGameListOpenFolder(u64 program_id, GameListOpenTarget target); - void OnGameListNavigateToGamedbEntry(u64 program_id, CompatibilityList& compatibility_list); + void OnGameListNavigateToGamedbEntry(u64 program_id, + const CompatibilityList& compatibility_list); void OnMenuLoadFile(); void OnMenuLoadFolder(); void OnMenuInstallToNAND();