From d210170f36ec29c9f73430d1ec21f7784ca0aa73 Mon Sep 17 00:00:00 2001 From: NeatNit Date: Sat, 6 Oct 2018 11:57:50 +0300 Subject: [PATCH] CONTRIBUTING.md - remove note about casting numeric types Apparently it's not true: https://github.com/citra-emu/citra/pull/4310#discussion_r223174725 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 008dc5b50..1b2056885 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,7 +22,7 @@ If clang format is found, then cmake will add a custom build target that can be * Don't ever introduce new external dependencies into Core * Don't use any platform specific code in Core * Use namespaces often -* Avoid the use of C-style casts and instead prefer C++-style `static_cast` and `reinterpret_cast`. Try to avoid using `dynamic_cast`. Never use `const_cast`. The only exception to this rule is for casting between two numeric types, where C-style casts are encouraged for brevity and readability. +* Avoid the use of C-style casts and instead prefer C++-style `static_cast` and `reinterpret_cast`. Try to avoid using `dynamic_cast`. Never use `const_cast`. ### Naming Rules * Functions: `PascalCase`