From 79f970e6de4429926e226910018f53fe3dc7ad48 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 5 Mar 2019 10:05:46 -0500 Subject: [PATCH 1/2] kernel/thread: Remove obsolete TODO in Create() This is a TODO carried over from Citra that doesn't apply here. --- src/core/hle/kernel/thread.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/core/hle/kernel/thread.cpp b/src/core/hle/kernel/thread.cpp index 6661e2130..eb54d6651 100644 --- a/src/core/hle/kernel/thread.cpp +++ b/src/core/hle/kernel/thread.cpp @@ -184,8 +184,6 @@ ResultVal> Thread::Create(KernelCore& kernel, std::string name return ERR_INVALID_PROCESSOR_ID; } - // TODO(yuriks): Other checks, returning 0xD9001BEA - if (!Memory::IsValidVirtualAddress(owner_process, entry_point)) { LOG_ERROR(Kernel_SVC, "(name={}): invalid entry {:016X}", name, entry_point); // TODO (bunnei): Find the correct error code to use here From 42085ff110ec6bf09d8823aa28c2047f7df9bbca Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 5 Mar 2019 10:15:03 -0500 Subject: [PATCH 2/2] video_core/surface: Remove obsolete TODO in PixelFormatFromRenderTargetFormat() This isn't needed anymore, according to Hexagon --- src/video_core/surface.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/video_core/surface.cpp b/src/video_core/surface.cpp index 044ba116a..a7ac26d71 100644 --- a/src/video_core/surface.cpp +++ b/src/video_core/surface.cpp @@ -89,8 +89,6 @@ PixelFormat PixelFormatFromDepthFormat(Tegra::DepthFormat format) { PixelFormat PixelFormatFromRenderTargetFormat(Tegra::RenderTargetFormat format) { switch (format) { - // TODO (Hexagon12): Converting SRGBA to RGBA is a hack and doesn't completely correct the - // gamma. case Tegra::RenderTargetFormat::RGBA8_SRGB: return PixelFormat::RGBA8_SRGB; case Tegra::RenderTargetFormat::RGBA8_UNORM: