From 64953f9bd31eec34a23d2f433ecec5293bd73c31 Mon Sep 17 00:00:00 2001 From: Lim Chee Aun Date: Tue, 28 Mar 2023 01:16:49 +0800 Subject: [PATCH] Remove this setState --- src/components/media.jsx | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/components/media.jsx b/src/components/media.jsx index 894316aa..2fdbce39 100644 --- a/src/components/media.jsx +++ b/src/components/media.jsx @@ -1,5 +1,5 @@ import { getBlurHashAverageColor } from 'fast-blurhash'; -import { useCallback, useRef, useState } from 'preact/hooks'; +import { useCallback, useRef } from 'preact/hooks'; import QuickPinchZoom, { make3dTransformValue } from 'react-quick-pinch-zoom'; import Icon from './icon'; @@ -51,8 +51,6 @@ function Media({ media, showOriginal, autoAnimate, onClick = () => {} }) { } }, []); - const [imageLoaded, setImageLoaded] = useState(false); - if (type === 'image' || (type === 'unknown' && previewUrl && url)) { // Note: type: unknown might not have width/height return ( @@ -60,15 +58,13 @@ function Media({ media, showOriginal, autoAnimate, onClick = () => {} }) { class={`media media-image`} onClick={onClick} style={ - showOriginal && - !imageLoaded && { + showOriginal && { backgroundImage: `url(${previewUrl})`, } } > {showOriginal ? ( {} }) { loading="eager" decoding="async" onLoad={(e) => { - setImageLoaded(true); + e.target.closest('.media-image').style.backgroundImage = ''; }} /> @@ -106,7 +102,7 @@ function Media({ media, showOriginal, autoAnimate, onClick = () => {} }) { backgroundPosition: focalBackgroundPosition || 'center', }} onLoad={(e) => { - setImageLoaded(true); + e.target.closest('.media-image').style.backgroundImage = ''; }} /> )}