From 15578835a87de195113f6cc9295f05a6c175a811 Mon Sep 17 00:00:00 2001 From: Blake Smith Date: Fri, 15 Mar 2024 05:36:43 -0500 Subject: [PATCH] [chore] Different error message for net/mail parsing on go 1.21.8 and above (#2760) go 1.21.8 fixed some minor issues in net/mail that causes the test suite to fail for some mail validation cases. Although we're not on go 1.21.8 yet, make the test forward and backwards compatible. See: https://github.com/golang/go/commit/263c059b09fdd40d9dd945f2ecb20c89ea28efe5 --- internal/validate/formvalidation_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/validate/formvalidation_test.go b/internal/validate/formvalidation_test.go index 578b300ea..7c1ff7b7f 100644 --- a/internal/validate/formvalidation_test.go +++ b/internal/validate/formvalidation_test.go @@ -144,7 +144,10 @@ func (suite *ValidationTestSuite) TestValidateEmail() { err = validate.Email(almostAnEmailAddress) if suite.Error(err) { - suite.Equal(errors.New("mail: no angle-addr"), err) + suite.True("mail: no angle-addr" == err.Error() || + // golang 1.21.8 fixed some inconsistencies in net/mail which leads + // to different error messages. + "mail: missing word in phrase: mail: invalid string" == err.Error()) } err = validate.Email(aWebsite)