From d4eca46bba66daba04c585cf76b7e0ae04693da7 Mon Sep 17 00:00:00 2001 From: Zephyron Date: Wed, 5 Feb 2025 15:13:10 +1000 Subject: [PATCH] frontend: Remove telemetry popup and default to disabled Removes the telemetry opt-in popup dialog and defaults telemetry to disabled. The ShowTelemetryCallout function is simplified to just: - Set telemetry to disabled by default - Apply the setting - Mark the callout as shown to prevent future popups This change ensures user privacy by defaulting to no telemetry collection without requiring user interaction. --- src/citron/main.cpp | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/citron/main.cpp b/src/citron/main.cpp index 7fa8e7ebd..29fd143b2 100644 --- a/src/citron/main.cpp +++ b/src/citron/main.cpp @@ -1,4 +1,5 @@ // SPDX-FileCopyrightText: 2014 Citra Emulator Project +// SPDX-FileCopyrightText: 2025 citron Emulator Project // SPDX-License-Identifier: GPL-2.0-or-later #include @@ -203,21 +204,13 @@ enum class CalloutFlag : uint32_t { }; void GMainWindow::ShowTelemetryCallout() { - if (UISettings::values.callout_flags.GetValue() & - static_cast(CalloutFlag::Telemetry)) { - return; - } + // Default telemetry to disabled without showing popup + Settings::values.enable_telemetry = false; + system->ApplySettings(); + // Mark telemetry callout as shown to prevent future popups UISettings::values.callout_flags = UISettings::values.callout_flags.GetValue() | static_cast(CalloutFlag::Telemetry); - const QString telemetry_message = - tr("Anonymous " - "data is collected to help improve citron. " - "

Would you like to share your usage data with us?"); - if (!question(this, tr("Telemetry"), telemetry_message)) { - Settings::values.enable_telemetry = false; - system->ApplySettings(); - } } const int GMainWindow::max_recent_files_item;